http://searchfox.org/mozilla-central/rev/01d27fdd3946f7210da91b18fcccca01d7324fe2/dom/base/test/test_data_uri.html#82 is not guaranteed to run before http://searchfox.org/mozilla-central/rev/01d27fdd3946f7210da91b18fcccca01d7324fe2/dom/base/test/test_data_uri.html#28 so it's not surprising to have error message like the following: [task 2017-07-17T10:19:15.400501Z] 10:19:15 ERROR - /tests/dom/base/test/test_data_uri.html logged result after SimpleTest.finish(): iframe should have NullPrincipal
Created attachment 8887009 [details] [diff] [review] Bug1381437.patch
Assignee: nobody → hchang
Attachment #8887008 - Attachment is obsolete: true
Status: NEW → ASSIGNED
Hi Olli, Since the original reviewer of test_data_uri.html is you, I am firstly asking for your review :) This test case is racy because of comment 0 and has been fixed by my patch. (I haven't triggered a try run to verify but I am very confident since it's quite obvious.) Could you please review my patch? Thanks!
Comment on attachment 8887009 [details] [diff] [review] Bug1381437.patch Well, the original patch author should review, but I can review too. rs+
Attachment #8887009 - Flags: review?(bugs) → review+
Asking Yoshi for review as well since he is the original author.
Attachment #8887009 - Flags: review?(allstars.chh)
Attachment #8887009 - Flags: review?(allstars.chh) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/728b31173deb9b63a2391b8a00fc4da5f4ab439e Bug 1381437 - Re-org testing promises to avoid racy tesing result. r=smaug, yoshi
Summary: Fix racy test case: test_data_uri.html → Fix racing test case: test_data_uri.html
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.