Closed
Bug 1381466
Opened 7 years ago
Closed 7 years ago
Throw TypeError when comparator is not callable in [Typed]Array.prototype.sort
Categories
(Core :: JavaScript: Standard Library, defect)
Core
JavaScript: Standard Library
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
Details
Attachments
(1 file)
|
5.92 KB,
patch
|
till
:
review+
|
Details | Diff | Splinter Review |
Per https://github.com/tc39/ecma262/commit/564b30b3b1bbba3772a2ebeb58208043713d64fe, Array.prototype.sort and %TypedArray%.prototype.sort now perform a IsCallable check when entering the method.
|
Assignee | |
Comment 1•7 years ago
|
||
Another small ES2018 update: Array.p.sort and TypedArray.p.sort now perform a IsCallable check when the comparator argument was provided.
Attachment #8887028 -
Flags: review?(till)
|
||
Comment 2•7 years ago
|
||
Comment on attachment 8887028 [details] [diff] [review] bug1381466.patch Review of attachment 8887028 [details] [diff] [review]: ----------------------------------------------------------------- r=me
Attachment #8887028 -
Flags: review?(till) → review+
|
|
Assignee | |
Comment 3•7 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d929d586209513f21fe082c7d03f2e4e97c43e68
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/bfd711e5156c Throw TypeError when comparator was provided, but is not callable per ES2018 draft spec. r=till
Keywords: checkin-needed
|
||
Comment 5•7 years ago
|
||
| bugherder | ||
https://hg.mozilla.org/mozilla-central/rev/bfd711e5156c
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•