Closed Bug 1381503 Opened 4 years ago Closed 4 years ago

Fine tune nsDisplayListBuilder::GetWidgetLayerManager

Categories

(Core :: Web Painting, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: u459114, Assigned: u459114)

References

Details

Attachments

(3 files)

nsDisplayText::nsDisplayText is one of users of nsDisplayListBuilder::GetWidgetLayerManager, and it does not pass aViewer param to GetWidgetLayerManager

LayerManager*
nsDisplayListBuilder::GetWidgetLayerManager(nsView** aView)
{
  nsView* view = RootReferenceFrame()->GetView(); << wasting time
  if (aView) {
    *aView = view;
  }

The first line of nsDisplayListBuilder::GetWidgetLayerManager is not needed if aView is nullptr
Search nsDisplayListBuilder::GetWidgetLayerManager, it takes 1.0 ms.
Blocks: 1351313
Attachment #8887072 - Flags: review?(matt.woodrow)
Attachment #8887100 - Flags: review?(matt.woodrow)
Comment on attachment 8887072 [details]
Bug 1381503 - Part 1. Fine tune nsDisplayListBuilder::GetWidgetLayerManager.

https://reviewboard.mozilla.org/r/157812/#review163080
Attachment #8887072 - Flags: review?(matt.woodrow) → review+
Comment on attachment 8887100 [details]
Bug 1381503 - Part 2. Do not use GetWidgetLayerManager if gfxPrefs::LayersAllowTextLayers return false.

https://reviewboard.mozilla.org/r/157854/#review163082
Attachment #8887100 - Flags: review?(matt.woodrow) → review+
Pushed by cku@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/287b244e6087
Part 1. Fine tune nsDisplayListBuilder::GetWidgetLayerManager. r=mattwoodrow
https://hg.mozilla.org/integration/autoland/rev/486da25b9ae0
Part 2. Do not use GetWidgetLayerManager if gfxPrefs::LayersAllowTextLayers return false. r=mattwoodrow
https://hg.mozilla.org/mozilla-central/rev/287b244e6087
https://hg.mozilla.org/mozilla-central/rev/486da25b9ae0
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.