Update font sizes in about:debugging

VERIFIED FIXED in Firefox 56

Status

VERIFIED FIXED
a year ago
5 months ago

People

(Reporter: mstriemer, Assigned: mstriemer)

Tracking

unspecified
Firefox 56

Firefox Tracking Flags

(firefox56 verified)

Details

Attachments

(3 attachments)

(Assignee)

Description

a year ago
The mocks [1] have the add-on's title bold and smaller text for it's attributes. We should update the fonts to match the mocks.

[1] https://mozilla.invisionapp.com/share/RUA0FEJSW#/screens/220706957
(Assignee)

Comment 1

a year ago
Created attachment 8887242 [details]
updated-fonts.png

Emanuela, do these font sizes look good to you? I made the headings 1.5rem which works out to about 17px on a Mac, it wasn't specified in the mocks.
Flags: needinfo?(emanuela)

Comment 2

a year ago
It looks quite right. 
Can we try to have it with ~15px, Semibold 600?
Flags: needinfo?(emanuela)

Comment 3

a year ago
Created attachment 8887374 [details]
about-debugging-sizing.jpg

Attaching a file with font-sizing to avoid misunderstanding :)

(more info on the type-scale can be found here: http://design.firefox.com/photon/visual/typography.html)
Comment hidden (mozreview-request)

Comment 5

a year ago
mozreview-review
Comment on attachment 8887986 [details]
Bug 1381550 - Update font sizes in about:debugging

https://reviewboard.mozilla.org/r/158854/#review164334

Very nice! Thanks for the patch Mark.
Attachment #8887986 - Flags: review?(jdescottes) → review+
(Assignee)

Updated

a year ago
Keywords: checkin-needed

Comment 6

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8af8abf2aa0d
Update font sizes in about:debugging r=jdescottes
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/8af8abf2aa0d
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
I can see the feature implemented in Nightly 56.0a1 on Linux Mint(64 Bit)

Build ID 	20170722100652
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0
QA Whiteboard: [bugday-20170719]

Comment 9

a year ago
The feature has been implemented in latest Nightly 56.0a1 on Windows 10, 64-bit  

Build ID    :	20170722030204
User Agent  : 	Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0

[bugday-20170719]

Updated

a year ago
Status: RESOLVED → VERIFIED
status-firefox56: fixed → verified

Updated

5 months ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.