Closed
Bug 1381550
Opened 8 years ago
Closed 8 years ago
Update font sizes in about:debugging
Categories
(DevTools :: about:debugging, enhancement)
DevTools
about:debugging
Tracking
(firefox56 verified)
VERIFIED
FIXED
Firefox 56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | verified |
People
(Reporter: mstriemer, Assigned: mstriemer)
Details
Attachments
(3 files)
updated-fonts.png
The mocks [1] have the add-on's title bold and smaller text for it's attributes. We should update the fonts to match the mocks.
[1] https://mozilla.invisionapp.com/share/RUA0FEJSW#/screens/220706957
|
Assignee | |
Comment 1•8 years ago
|
||
Emanuela, do these font sizes look good to you? I made the headings 1.5rem which works out to about 17px on a Mac, it wasn't specified in the mocks.
Flags: needinfo?(emanuela)
|
||
Comment 2•8 years ago
|
||
It looks quite right.
Can we try to have it with ~15px, Semibold 600?
Flags: needinfo?(emanuela)
|
|
||
Comment 3•8 years ago
|
||
Attaching a file with font-sizing to avoid misunderstanding :)
(more info on the type-scale can be found here: http://design.firefox.com/photon/visual/typography.html)
| Comment hidden (mozreview-request) |
|
||
Comment 5•8 years ago
|
||
| mozreview-review | ||
Comment on attachment 8887986 [details]
Bug 1381550 - Update font sizes in about:debugging
https://reviewboard.mozilla.org/r/158854/#review164334
Very nice! Thanks for the patch Mark.
Attachment #8887986 -
Flags: review?(jdescottes) → review+
|
|
Assignee | |
Updated•8 years ago
|
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/8af8abf2aa0d
Update font sizes in about:debugging r=jdescottes
Keywords: checkin-needed
|
||
Comment 7•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
|
||
Comment 8•8 years ago
|
||
I can see the feature implemented in Nightly 56.0a1 on Linux Mint(64 Bit)
Build ID 20170722100652
User Agent Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0
QA Whiteboard: [bugday-20170719]
|
||
Comment 9•8 years ago
|
||
The feature has been implemented in latest Nightly 56.0a1 on Windows 10, 64-bit
Build ID : 20170722030204
User Agent : Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0
[bugday-20170719]
|
|
||
Updated•8 years ago
|
Status: RESOLVED → VERIFIED
|
||
Updated•7 years ago
|
Product: Firefox → DevTools
You need to log in
before you can comment on or make changes to this bug.
Description
•