Closed
Bug 1381560
Opened 7 years ago
Closed 7 years ago
Panic reason string length is stored twice.
Categories
(Toolkit :: Crash Reporting, defect)
Toolkit
Crash Reporting
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: nika, Assigned: nika)
References
Details
Attachments
(1 file)
2.90 KB,
patch
|
ted
:
review+
|
Details | Diff | Splinter Review |
In bug 1275780, we started collecting the panic string through a hook and storing it in a static. TO do this the data structure was added here: http://searchfox.org/mozilla-central/source/toolkit/library/rust/shared/lib.rs#41 This type unnecessarily stores the length of the string twice. Like `&str`, `*const str` is a fat pointer containing both the address of the start of the string, and the length of the string, meaning that the second `usize` should be unnecessary.
Assignee | ||
Comment 1•7 years ago
|
||
MozReview-Commit-ID: rLOdMPxhwD
Attachment #8887132 -
Flags: review?(ted)
Comment 2•7 years ago
|
||
Comment on attachment 8887132 [details] [diff] [review] Stop storing panic string length twice Review of attachment 8887132 [details] [diff] [review]: ----------------------------------------------------------------- Oh, hah! I guess I was thinking in C terms there. :)
Attachment #8887132 -
Flags: review?(ted) → review+
Pushed by michael@thelayzells.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/4d0a260acd3f Stop storing panic string length twice, r=ted
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/4d0a260acd3f
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•