Closed Bug 1381573 Opened 7 years ago Closed 7 years ago

Use callOnClose instead of onShutdown in ext-url-overrides.js

Categories

(WebExtensions :: General, enhancement, P2)

enhancement

Tracking

(firefox56 fixed)

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: bsilverberg, Assigned: bsilverberg)

Details

(Whiteboard: triaged)

Attachments

(1 file)

The code in onShutdown in ext-url-overrides.js [1] processes the new tab setting even when no new tab setting exists for an extension. This is unnecessary and should be avoided.

[1] http://searchfox.org/mozilla-central/rev/01d27fdd3946f7210da91b18fcccca01d7324fe2/browser/components/extensions/ext-url-overrides.js#57-69
Summary: onShutdown processes new tab overrides even when not necessary → Use callOnClose instead of onShutdown in ext-url-overrides.js
Attachment #8887157 - Flags: review?(aswan)
Depends on: 1381297
No longer depends on: 1381297
Comment on attachment 8887157 [details]
Bug 1381573 - Use callOnClose instead of onShutdown in ext-url-overrides.js,

https://reviewboard.mozilla.org/r/157902/#review165868
Attachment #8887157 - Flags: review?(aswan) → review+
Pushed by bsilverberg@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/5227744e2508
Use callOnClose instead of onShutdown in ext-url-overrides.js, r=aswan
https://hg.mozilla.org/mozilla-central/rev/5227744e2508
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.