1381573 - Use callOnClose instead of onShutdown in ext-url-overrides.js

Status: RESOLVED FIXED

(WebExtensions :: General, enhancement, P2)

Description

[Bob Silverberg [:bsilverberg]]

The code in onShutdown in ext-url-overrides.js [1] processes the new tab setting even when no new tab setting exists for an extension. This is unnecessary and should be avoided.

[1] http://searchfox.org/mozilla-central/rev/01d27fdd3946f7210da91b18fcccca01d7324fe2/browser/components/extensions/ext-url-overrides.js#57-69

Comment 1

[Bob Silverberg [:bsilverberg]]

Attachment: Bug 1381573 - Use callOnClose instead of onShutdown in ext-url-overrides.js,

Review commit: https://reviewboard.mozilla.org/r/157902/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157902/

Comment 2

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8887157 [details]
Bug 1381573 - Use callOnClose instead of onShutdown in ext-url-overrides.js,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157902/diff/1-2/

Comment 3

[Bob Silverberg [:bsilverberg]]

Comment on attachment 8887157 [details]
Bug 1381573 - Use callOnClose instead of onShutdown in ext-url-overrides.js,

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157902/diff/2-3/

Comment 4

[Andrew Swan [:aswan]]

Comment on attachment 8887157 [details]
Bug 1381573 - Use callOnClose instead of onShutdown in ext-url-overrides.js,

https://reviewboard.mozilla.org/r/157902/#review165868

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5227744e2508
Use callOnClose instead of onShutdown in ext-url-overrides.js, r=aswan

Comment 6

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/5227744e2508