1381590 - Storage Inspector doesn't show storage for file:// URLs

Status: RESOLVED FIXED

(DevTools :: Storage Inspector, defect, P2)

Description

[alfred_z]

User Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:54.0) Gecko/20100101 Firefox/54.0
Build ID: 20170628075643

Steps to reproduce:

I created a start page as local html file that makes use of the IndexedDB APIs.
Then I activated the storage inspector and tried to inspect the created DB entries.


Actual results:

The page - and by extension the API itself - works as intended, but the created database isn't shown in the IndexedDB section of the storage inspector.



Expected results:

The storage inspector should have shown the created database and its content.

However, it works if the file gets served e.g. via localhost instead of directly opening the file.
This might be a regression of a resolved bug from about 8 months ago.

Comment 1

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Sounds like a security change must have broken this one.

Comment 2

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Attachment: Bug 1381590 - Make Storage Inspector work with file:// URLs

Review commit: https://reviewboard.mozilla.org/r/227086/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/227086/

Comment 3

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8958145 [details]
Bug 1381590 - Make Storage Inspector work with file:// URLs

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/227086/diff/1-2/

Comment 4

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8958145 [details]
Bug 1381590 - Make Storage Inspector work with file:// URLs

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/227086/diff/2-3/

Comment 5

[Patrick Brosset <:pbro>]

Comment on attachment 8958145 [details]
Bug 1381590 - Make Storage Inspector work with file:// URLs

https://reviewboard.mozilla.org/r/227086/#review233428

Comment 6

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8958145 [details]
Bug 1381590 - Make Storage Inspector work with file:// URLs

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/227086/diff/3-4/

Comment 7

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8958145 [details]
Bug 1381590 - Make Storage Inspector work with file:// URLs

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/227086/diff/4-5/

Comment 8

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8958145 [details]
Bug 1381590 - Make Storage Inspector work with file:// URLs

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/227086/diff/5-6/

Comment 9

[Mike Ratcliffe [:miker] [:mratcliffe] [:mikeratcliffe]]

Comment on attachment 8958145 [details]
Bug 1381590 - Make Storage Inspector work with file:// URLs

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/227086/diff/6-7/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/71eb44102dd4
Make Storage Inspector work with file:// URLs r=pbro

Comment 11

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/71eb44102dd4