Remove unused fields of nsIDOMHTMLHRElement and nsIDOMHTMLOptGroupElement.idl

RESOLVED FIXED in Firefox 56

Status

()

Core
DOM: Core & HTML
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: mccr8, Assigned: mccr8)

Tracking

(Blocks: 1 bug)

unspecified
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

6 months ago
It is probably silly to file individual bugs for these bug oh well.
(Assignee)

Updated

6 months ago
Summary: Remove unused fields of nsIDOMHTMLHRElement → Remove unused fields of nsIDOMHTMLHRElement and nsIDOMHTMLOptGroupElement.idl
Comment hidden (mozreview-request)
Comment on attachment 8887237 [details]
Bug 1381615 - Remove unused fields from nsIDOMHTMLHRElement and nsIDOMHTMLOptGroupElement.

https://reviewboard.mozilla.org/r/158040/#review163166

::: dom/html/HTMLHRElement.h:42
(Diff revision 1)
>    virtual nsMapRuleToAttributesFunc GetAttributeMappingFunction() const override;
>    virtual nsresult Clone(mozilla::dom::NodeInfo *aNodeInfo, nsINode **aResult,
>                           bool aPreallocateChildren) const override;
>  
>    // WebIDL API
> +  void GetAlign(nsAString& aValue) const

`GetHTMLAttr(nsGkAtoms::align, aValue)`, please.

::: dom/html/HTMLHRElement.h:53
(Diff revision 1)
>      SetHTMLAttr(nsGkAtoms::align, aAlign, aError);
>    }
>  
> -  // The XPCOM GetColor is OK for us
> +  void GetColor(nsAString& aValue) const
> +  {
> +    GetAttr(kNameSpaceID_None, nsGkAtoms::color, aValue);

GetHTMLAttr.

::: dom/html/HTMLHRElement.h:71
(Diff revision 1)
>      SetHTMLBoolAttr(nsGkAtoms::noshade, aNoShade, aError);
>    }
>  
> -  // The XPCOM GetSize is OK for us
> +  void GetSize(nsAString& aValue) const
> +  {
> +    GetAttr(kNameSpaceID_None, nsGkAtoms::size, aValue);

GetHTMLAttr.

::: dom/html/HTMLHRElement.h:80
(Diff revision 1)
>      SetHTMLAttr(nsGkAtoms::size, aSize, aError);
>    }
>  
> -  // The XPCOM GetWidth is OK for us
> +  void GetWidth(nsAString& aValue) const
> +  {
> +    GetAttr(kNameSpaceID_None, nsGkAtoms::width, aValue);

GetHTMLAttr.

::: dom/interfaces/html/nsIDOMHTMLOptGroupElement.idl:11
(Diff revision 1)
> - */
>  
>  [uuid(6fa79f99-4ce4-4634-840a-867fcfb32dba)]
>  interface nsIDOMHTMLOptGroupElement : nsISupports
>  {
> -           attribute boolean          disabled;
> +           // This is used in nsListControlFrame.cpp.

This is fine, but we could also replace the QI there with HTMLOptGroupElement::FromContent to nix this prop as well.  r=me either way
Attachment #8887237 - Flags: review?(bzbarsky) → review+
(Assignee)

Comment 3

6 months ago
(In reply to Boris Zbarsky [:bz] from comment #2)
> `GetHTMLAttr(nsGkAtoms::align, aValue)`, please.
Oops, I was just mindlessly inlining the macro. I've fixed all of these.

> This is fine, but we could also replace the QI there with
> HTMLOptGroupElement::FromContent to nix this prop as well.  r=me either way

Ah, I see. I've gone ahead and used FromContent and removed the field from the .idl file.
Comment hidden (mozreview-request)

Comment 5

6 months ago
Pushed by amccreight@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a84e140e9929
Remove unused fields from nsIDOMHTMLHRElement and nsIDOMHTMLOptGroupElement. r=bz

Comment 6

6 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/a84e140e9929
Status: NEW → RESOLVED
Last Resolved: 6 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
(Assignee)

Updated

6 months ago
Blocks: 1387169
You need to log in before you can comment on or make changes to this bug.