1381615 - Remove unused fields of nsIDOMHTMLHRElement and nsIDOMHTMLOptGroupElement.idl

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, enhancement)

Description

[Andrew McCreight [:mccr8]]

It is probably silly to file individual bugs for these bug oh well.

Comment 1

[Andrew McCreight [:mccr8]]

Attachment: Bug 1381615 - Remove unused fields from nsIDOMHTMLHRElement and nsIDOMHTMLOptGroupElement.

Review commit: https://reviewboard.mozilla.org/r/158040/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158040/

Comment 2

[Boris Zbarsky [:bzbarsky]]

Comment on attachment 8887237 [details]
Bug 1381615 - Remove unused fields from nsIDOMHTMLHRElement and nsIDOMHTMLOptGroupElement.

https://reviewboard.mozilla.org/r/158040/#review163166

::: dom/html/HTMLHRElement.h:42
(Diff revision 1)
>    virtual nsMapRuleToAttributesFunc GetAttributeMappingFunction() const override;
>    virtual nsresult Clone(mozilla::dom::NodeInfo *aNodeInfo, nsINode **aResult,
>                           bool aPreallocateChildren) const override;
>  
>    // WebIDL API
> +  void GetAlign(nsAString& aValue) const

`GetHTMLAttr(nsGkAtoms::align, aValue)`, please.

::: dom/html/HTMLHRElement.h:53
(Diff revision 1)
>      SetHTMLAttr(nsGkAtoms::align, aAlign, aError);
>    }
>  
> -  // The XPCOM GetColor is OK for us
> +  void GetColor(nsAString& aValue) const
> +  {
> +    GetAttr(kNameSpaceID_None, nsGkAtoms::color, aValue);

GetHTMLAttr.

::: dom/html/HTMLHRElement.h:71
(Diff revision 1)
>      SetHTMLBoolAttr(nsGkAtoms::noshade, aNoShade, aError);
>    }
>  
> -  // The XPCOM GetSize is OK for us
> +  void GetSize(nsAString& aValue) const
> +  {
> +    GetAttr(kNameSpaceID_None, nsGkAtoms::size, aValue);

GetHTMLAttr.

::: dom/html/HTMLHRElement.h:80
(Diff revision 1)
>      SetHTMLAttr(nsGkAtoms::size, aSize, aError);
>    }
>  
> -  // The XPCOM GetWidth is OK for us
> +  void GetWidth(nsAString& aValue) const
> +  {
> +    GetAttr(kNameSpaceID_None, nsGkAtoms::width, aValue);

GetHTMLAttr.

::: dom/interfaces/html/nsIDOMHTMLOptGroupElement.idl:11
(Diff revision 1)
> - */
>  
>  [uuid(6fa79f99-4ce4-4634-840a-867fcfb32dba)]
>  interface nsIDOMHTMLOptGroupElement : nsISupports
>  {
> -           attribute boolean          disabled;
> +           // This is used in nsListControlFrame.cpp.

This is fine, but we could also replace the QI there with HTMLOptGroupElement::FromContent to nix this prop as well.  r=me either way

Comment 3

[Andrew McCreight [:mccr8]]

(In reply to Boris Zbarsky [:bz] from comment #2)
> `GetHTMLAttr(nsGkAtoms::align, aValue)`, please.
Oops, I was just mindlessly inlining the macro. I've fixed all of these.

> This is fine, but we could also replace the QI there with
> HTMLOptGroupElement::FromContent to nix this prop as well.  r=me either way

Ah, I see. I've gone ahead and used FromContent and removed the field from the .idl file.

Comment 4

[Andrew McCreight [:mccr8]]

Comment on attachment 8887237 [details]
Bug 1381615 - Remove unused fields from nsIDOMHTMLHRElement and nsIDOMHTMLOptGroupElement.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158040/diff/1-2/

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a84e140e9929
Remove unused fields from nsIDOMHTMLHRElement and nsIDOMHTMLOptGroupElement. r=bz

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a84e140e9929