Enable the new console frontend in DAMP

RESOLVED FIXED in Firefox 56

Status

DevTools
Console
P1
normal
RESOLVED FIXED
11 months ago
6 days ago

People

(Reporter: bgrins, Assigned: bgrins)

Tracking

unspecified
Firefox 56
Dependency tree / graph
Bug Flags:
qe-verify -

Firefox Tracking Flags

(firefox56 fixed)

Details

(Whiteboard: [console-html])

MozReview Requests

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(2 attachments)

(Assignee)

Description

11 months ago
Right now the old console is forced on in DAMP. Since we are planning to let the new console ride the trains in 56, let's go ahead and enable it in DAMP now.
(Assignee)

Updated

11 months ago
Depends on: 1326937
Comment hidden (mozreview-request)

Updated

11 months ago
Whiteboard: [console-html] → [console-html] [triage]
Comment hidden (mozreview-request)

Updated

11 months ago
Assignee: nobody → bgrinstead
Status: NEW → ASSIGNED
Flags: qe-verify-
Priority: -- → P1
Whiteboard: [console-html] [triage] → [console-html]

Updated

11 months ago
Iteration: --- → 56.3 - Jul 24

Comment 3

11 months ago
mozreview-review
Comment on attachment 8887236 [details]
Bug 1381636 - Enable the new console frontend in DAMP;

https://reviewboard.mozilla.org/r/158036/#review164106

Good!

Honza
Attachment #8887236 - Flags: review?(odvarko) → review+
(Assignee)

Comment 4

11 months ago
Results are in: https://treeherder.mozilla.org/perf.html#/compare?originalProject=try&originalRevision=41fea2aab1a11eac1f37f3270e825d1bf2345d78&newProject=try&newRevision=0b62926e7bedc9977e0ae5776e05e488c7a8ec28&framework=1&filter=damp&showOnlyImportant=0

This doesn't change much on Windows or Linux, everything is the same or modestly improved (anywhere from 0-5%)

Linux: https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=try&originalRevision=41fea2aab1a11eac1f37f3270e825d1bf2345d78&newProject=try&newRevision=0b62926e7bedc9977e0ae5776e05e488c7a8ec28&originalSignature=edaec66500db21d37602c99daa61ac983f21a6ac&newSignature=edaec66500db21d37602c99daa61ac983f21a6ac&filter=console&framework=1
Win10: https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=try&originalRevision=41fea2aab1a11eac1f37f3270e825d1bf2345d78&newProject=try&newRevision=0b62926e7bedc9977e0ae5776e05e488c7a8ec28&originalSignature=f687ee347bcbdc55828148af029908049de69b7f&newSignature=f687ee347bcbdc55828148af029908049de69b7f&filter=console&framework=1
Win7: https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=try&originalRevision=41fea2aab1a11eac1f37f3270e825d1bf2345d78&newProject=try&newRevision=0b62926e7bedc9977e0ae5776e05e488c7a8ec28&originalSignature=63c652b34bd8fcf3623be048bdd3104906f70f02&newSignature=63c652b34bd8fcf3623be048bdd3104906f70f02&filter=console&framework=1

But on OSX the overall DAMP time isn't affected much but we have a lot of variation in the console. Much worse bulk log, much better stream log, worse open, and better close. Note that the open time is correlated to the bulk log time (since it displays cached messages at startup). I don't know why OSX is so different from the others. I can re-run once Bug 1326937 lands.

OSX: https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=try&originalRevision=41fea2aab1a11eac1f37f3270e825d1bf2345d78&newProject=try&newRevision=0b62926e7bedc9977e0ae5776e05e488c7a8ec28&originalSignature=9663a154caf9b713fb951c8db24518c7e0ceddce&newSignature=9663a154caf9b713fb951c8db24518c7e0ceddce&filter=console&framework=1
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 9

11 months ago
mozreview-review
Comment on attachment 8889514 [details]
Bug 1381636 - Bump and sign a new version of damp;

https://reviewboard.mozilla.org/r/160540/#review165844

thanks for keeping this updated
Attachment #8889514 - Flags: review?(jmaher) → review+

Comment 10

11 months ago
Pushed by bgrinstead@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e3fa073f5b94
Enable the new console frontend in DAMP;r=Honza
https://hg.mozilla.org/integration/autoland/rev/64d4132ab907
Bump and sign a new version of damp;r=jmaher

Updated

11 months ago
Iteration: 56.3 - Jul 24 → 56.4 - Aug 1

Comment 11

11 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/e3fa073f5b94
https://hg.mozilla.org/mozilla-central/rev/64d4132ab907
Status: ASSIGNED → RESOLVED
Last Resolved: 11 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56

Updated

6 days ago
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.