Closed Bug 1381669 Opened 3 years ago Closed 3 years ago

port backfill to actions.json

Categories

(Taskcluster :: Services, enhancement)

enhancement
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla56

People

(Reporter: bstack, Assigned: bstack)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Comment on attachment 8888063 [details]
* Bug 1381669 - Port backfilling to actions.json

https://reviewboard.mozilla.org/r/158948/#review165316

::: taskcluster/actions/backfill.py:26
(Diff revision 2)
> +
> +@register_callback_action(
> +    title='Backfill',
> +    name='backfill',
> +    symbol='Bk',
> +    description='Adds a specific job to previous pushes.',

"Runs this job on previous pushes" -- it took me a minute to figure out *which* specific job..

::: taskcluster/actions/backfill.py:57
(Diff revision 2)
> +        pushlog_url = PUSHLOG_TMPL.format(parameters['head_repository'], start_id, end_id)
> +        r = requests.get(pushlog_url)
> +        r.raise_for_status()
> +        pushes = pushes + r.json()['pushes'].keys()
> +        if len(pushes) >= depth:
> +            break

I think you want to decrement `end_id` here?

::: taskcluster/actions/backfill.py:61
(Diff revision 2)
> +        if len(pushes) >= depth:
> +            break
> +    pushes = sorted(pushes)[-depth:]
> +
> +    r = requests.get(pushlog_url)
> +    r.raise_for_status()

Why request this again?

::: taskcluster/actions/util.py:36
(Diff revision 2)
>      label = task_def['metadata']['name']
>      session = get_session()
>      create.create_task(session, task_id, label, task_def)
> +
> +
> +def clone_and_update_task(task, deadline, expires):

We talked about this in irc.  I think you can just use some of the `taskgraph.util.parameterization` stuff I made in my patch.
Attachment #8888063 - Flags: review?(dustin)
Attachment #8888063 - Attachment is obsolete: true
Attachment #8891103 - Flags: review?(dustin)
Comment on attachment 8891103 [details]
Bug 1381669 - Add backfill as an actions.json task

https://reviewboard.mozilla.org/r/162282/#review167828
Attachment #8891103 - Flags: review?(dustin) → review+
Pushed by dmitchell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c2c67f39a75e
Add backfill as an actions.json task r=dustin
Backout by kwierso@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/20ca66b2d539
Backed out changeset c2c67f39a75e
https://hg.mozilla.org/mozilla-central/rev/159e20b9dd04
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Component: Integration → Services
You need to log in before you can comment on or make changes to this bug.