1381726 - Remove smprintf_free

Status: RESOLVED FIXED

(Core :: XPCOM, enhancement)

Description

[Boris Zbarsky [:bzbarsky]]

We should just be able to free() instead.

Comment 1

[Nicholas Nethercote [inactive]]

One obstacle is that comm-central has about 15 uses under mailnews/.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: Replace nsTextFormatter::smprintf_free() uses with free()

jorgk, this compiles locally.

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: Remove nsTextFormatter::smprintf_free()

We can just use free() instead.

Comment 4

[Jorg K (CEST = GMT+2)]

Comment on attachment 8889333 [details] [diff] [review]
Replace nsTextFormatter::smprintf_free() uses with free()

Thanks for the heads-up!

Comment 5

[Eric Rahm [:erahm]]

Comment on attachment 8889334 [details] [diff] [review]
Remove nsTextFormatter::smprintf_free()

Review of attachment 8889334 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, another nice enhancement would be to have |smprintf| return a |UniquePtr| so we wouldn't have to worry about freeing at all.

Comment 6

[Nicholas Nethercote [inactive]]

> Looks good, another nice enhancement would be to have |smprintf| return a
> |UniquePtr| so we wouldn't have to worry about freeing at all.

Yes, both JS_smprintf() and Smprintf() do that and I might do it in a follow-up.

Comment 7

[Nicholas Nethercote [inactive]]

jorgk: BTW, you should be able to land the c-c patch immediately without waiting for the other patch to land on m-c.

Comment 8

[Jorg K (CEST = GMT+2)]

Thanks, I'm watching M-C merges anyway and I always need something to push after every M-C merge to trigger a full build.

Comment 9

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/49b4b43ce3a7b559fd7b33b0fe3c171b72c2cceb
Bug 1381726 - Remove nsTextFormatter::smprintf_free(). r=erahm.

Comment 10

[Jorg K (CEST = GMT+2)]

Putting "leave-open" since our pulsebot would close it otherwise.

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/29d8abec1e2a
Replace nsTextFormatter::smprintf_free() uses with free(). r=jorgk

Comment 12

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/49b4b43ce3a7