1381764 - stylo: Remove ComputedValuesInner, ParentStyleContextInfo, and PseudoInfo

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Emilio Cobos Álvarez [:emilio]]

These are three hacks that bug 1367904 that make me super sad and I don't really want to clean up... :(

Comment 1

[Emilio Cobos Álvarez [:emilio]]

Manish, you said you were going to clean all the mess post-landing, but I didn't see any bug for that.

We don't need any of this: ParentStyleContextInfo can just be an Option<&ComputedValues> that we already have in the cascade. PseudoInfo can just be an Option<&PseudoElement> that we can pass down there too. ComputedValuesInner is just a hack and should die IMO.

Comment 2

[Emilio Cobos Álvarez [:emilio]]

I'm doing part of this cleanup. This is just too annoying... I don't think I'd be in favor of landing hacks on tree, as temporary as they may be. They block stuff, and the tree is still orange.

Comment 3

[Emilio Cobos Álvarez [:emilio]]

Also there are a few things that are blatantly wrong with the new code... Writing patches as I write this.

Comment 4

[Emilio Cobos Álvarez [:emilio]]

Attachment: stylo: Fix PseudoElement::pseudo_type.

Review commit: https://reviewboard.mozilla.org/r/158330/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158330/

Comment 5

[Emilio Cobos Álvarez [:emilio]]

Attachment: stylo: remove unused Servo_StyleContext_NewContext.

Review commit: https://reviewboard.mozilla.org/r/158332/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158332/

Comment 6

[Emilio Cobos Álvarez [:emilio]]

Attachment: stylo: Make ComputedValues::to_outer_helper private.

Review commit: https://reviewboard.mozilla.org/r/158334/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158334/

Comment 7

[Emilio Cobos Álvarez [:emilio]]

Attachment: style: Cleanup most of the Inner mess.

Review commit: https://reviewboard.mozilla.org/r/158336/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158336/

Comment 8

[Emilio Cobos Álvarez [:emilio]]

Attachment: Bug 1381764: Cleanup the Gecko bits.

Review commit: https://reviewboard.mozilla.org/r/158338/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158338/

Comment 9

[Manish Goregaokar [:manishearth]]

Comment on attachment 8887481 [details]
stylo: remove unused Servo_StyleContext_NewContext.

https://reviewboard.mozilla.org/r/158332/#review163548

Comment 10

[Emilio Cobos Álvarez [:emilio]]

Attachment: style: More ComputedValuesInner cleanup.

Review commit: https://reviewboard.mozilla.org/r/158340/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158340/

Comment 11

[Manish Goregaokar [:manishearth]]

Comment on attachment 8887482 [details]
stylo: Make ComputedValues::to_outer_helper private.

https://reviewboard.mozilla.org/r/158334/#review163550

Comment 12

[Manish Goregaokar [:manishearth]]

Comment on attachment 8887483 [details]
style: Cleanup most of the Inner mess.

https://reviewboard.mozilla.org/r/158336/#review163556

Comment 13

[Manish Goregaokar [:manishearth]]

Comment on attachment 8887484 [details]
Bug 1381764: Cleanup the Gecko bits.

https://reviewboard.mozilla.org/r/158338/#review163558

Comment 14

[Manish Goregaokar [:manishearth]]

Comment on attachment 8887491 [details]
style: More ComputedValuesInner cleanup.

https://reviewboard.mozilla.org/r/158340/#review163562

Comment 15

[Manish Goregaokar [:manishearth]]

Comment on attachment 8887480 [details]
stylo: Fix PseudoElement::pseudo_type.

https://reviewboard.mozilla.org/r/158330/#review163568

Comment 16

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 8887481 [details]
stylo: remove unused Servo_StyleContext_NewContext.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158332/diff/1-2/

Comment 17

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 8887484 [details]
Bug 1381764: Cleanup the Gecko bits.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158338/diff/1-2/

Comment 18

[Emilio Cobos Álvarez [:emilio]]

Comment on attachment 8887491 [details]
style: More ComputedValuesInner cleanup.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158340/diff/1-2/

Comment 19

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6ee6f9f60c09
stylo: remove unused Servo_StyleContext_NewContext ; r=manishearth
https://hg.mozilla.org/integration/autoland/rev/7c637424657f
Cleanup the Gecko bits. r=manishearth
https://hg.mozilla.org/integration/autoland/rev/da7429cfbfa5
style: More ComputedValuesInner cleanup. r=Manishearth on a CLOSED TREE

Comment 20

[Mozilla Autoland]

We're sorry - something has gone wrong while rewriting or rebasing your commits. The commits being pushed no longer match what was requested. Please file a bug.

Comment 21

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6ee6f9f60c09
https://hg.mozilla.org/mozilla-central/rev/7c637424657f
https://hg.mozilla.org/mozilla-central/rev/da7429cfbfa5