Closed Bug 1381764 Opened 3 years ago Closed 3 years ago

stylo: Remove ComputedValuesInner, ParentStyleContextInfo, and PseudoInfo

Categories

(Core :: CSS Parsing and Computation, enhancement)

Product:
Core
Component:
CSS Parsing and Computation
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: emilio, Assigned: manishearth)

References

Details

Attachments

(3 files, 3 obsolete files)

stylo: remove unused Servo_StyleContext_NewContext.
59 bytes, text/x-review-board-request
manishearth
: review+
Details
Bug 1381764: Cleanup the Gecko bits.
59 bytes, text/x-review-board-request
manishearth
: review+
Details
style: More ComputedValuesInner cleanup.
59 bytes, text/x-review-board-request
manishearth
: review+
Details 
These are three hacks that bug 1367904 that make me super sad and I don't really want to clean up... :(
Manish, you said you were going to clean all the mess post-landing, but I didn't see any bug for that.

We don't need any of this: ParentStyleContextInfo can just be an Option<&ComputedValues> that we already have in the cascade. PseudoInfo can just be an Option<&PseudoElement> that we can pass down there too. ComputedValuesInner is just a hack and should die IMO.
Flags: needinfo?(manishearth)
I'm doing part of this cleanup. This is just too annoying... I don't think I'd be in favor of landing hacks on tree, as temporary as they may be. They block stuff, and the tree is still orange.
Also there are a few things that are blatantly wrong with the new code... Writing patches as I write this.
Comment on attachment 8887481 [details]
stylo: remove unused Servo_StyleContext_NewContext.

https://reviewboard.mozilla.org/r/158332/#review163548
Attachment #8887481 - Flags: review?(manishearth) → review+
Comment on attachment 8887482 [details]
stylo: Make ComputedValues::to_outer_helper private.

https://reviewboard.mozilla.org/r/158334/#review163550
Attachment #8887482 - Flags: review?(manishearth) → review+
Comment on attachment 8887483 [details]
style: Cleanup most of the Inner mess.

https://reviewboard.mozilla.org/r/158336/#review163556
Attachment #8887483 - Flags: review?(manishearth) → review+
Comment on attachment 8887484 [details]
Bug 1381764: Cleanup the Gecko bits.

https://reviewboard.mozilla.org/r/158338/#review163558
Attachment #8887484 - Flags: review?(manishearth) → review+
Comment on attachment 8887491 [details]
style: More ComputedValuesInner cleanup.

https://reviewboard.mozilla.org/r/158340/#review163562
Attachment #8887491 - Flags: review?(manishearth) → review+
Comment on attachment 8887480 [details]
stylo: Fix PseudoElement::pseudo_type.

https://reviewboard.mozilla.org/r/158330/#review163568
Attachment #8887480 - Flags: review+
Attachment #8887480 - Attachment is obsolete: true
Attachment #8887480 - Flags: review?(xidorn+moz)
Attachment #8887482 - Attachment is obsolete: true
Attachment #8887483 - Attachment is obsolete: true
Pushed by manishearth@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/6ee6f9f60c09
stylo: remove unused Servo_StyleContext_NewContext ; r=manishearth
https://hg.mozilla.org/integration/autoland/rev/7c637424657f
Cleanup the Gecko bits. r=manishearth
https://hg.mozilla.org/integration/autoland/rev/da7429cfbfa5
style: More ComputedValuesInner cleanup. r=Manishearth on a CLOSED TREE
We're sorry - something has gone wrong while rewriting or rebasing your commits. The commits being pushed no longer match what was requested. Please file a bug.
Flags: needinfo?(manishearth)
You need to log in before you can comment on or make changes to this bug.