Closed
Bug 1381766
Opened 8 years ago
Closed 8 years ago
Remove wrong assertions from CacheFile::SetNetworkTimes
Categories
(Core :: Networking: Cache, enhancement)
Core
Networking: Cache
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: michal, Assigned: michal)
References
Details
(Whiteboard: [necko-active])
Attachments
(1 file)
|
933 bytes,
patch
|
CuveeHsu
:
review+
|
Details | Diff | Splinter Review |
Assertions at http://searchfox.org/mozilla-central/rev/01d27fdd3946f7210da91b18fcccca01d7324fe2/netwerk/cache2/CacheFile.cpp#1256 are wrong. kIndexTimeNotAvailable has a special meaning when reading the times from the index, but measured times are passed to CacheFile::SetNetworkTimes and 65535ms is a valid time.
Attachment #8887379 -
Flags: review?(juhsu)
|
||
Comment 1•8 years ago
|
||
Comment on attachment 8887379 [details] [diff] [review]
fix
Review of attachment 8887379 [details] [diff] [review]:
-----------------------------------------------------------------
r=me
Thanks for catching this!
Attachment #8887379 -
Flags: review?(juhsu) → review+
|
Assignee | |
Updated•8 years ago
|
Assignee: nobody → michal.novotny
Whiteboard: [necko-active]
Pushed by mnovotny@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b0d89eca2c3c
Remove wrong assertions from CacheFile::SetNetworkTimes, r=junior
|
||
Comment 3•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•