Miscellaneous tooltool-download.sh changes

RESOLVED FIXED in Firefox 56

Status

()

Core
Build Config
RESOLVED FIXED
5 months ago
5 months ago

People

(Reporter: glandium, Assigned: glandium)

Tracking

unspecified
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(5 attachments)

Comment hidden (empty)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
(Assignee)

Updated

5 months ago
Blocks: 1381772

Comment 6

5 months ago
mozreview-review
Comment on attachment 8887387 [details]
Bug 1381770 - Use $WORKSPACE instead of $HOME/workspace in tooltool-download.sh.

https://reviewboard.mozilla.org/r/158232/#review164252
Attachment #8887387 - Flags: review?(mshal) → review+

Comment 7

5 months ago
mozreview-review
Comment on attachment 8887388 [details]
Bug 1381770 - Enable multiple download retries in tooltool-download.sh.

https://reviewboard.mozilla.org/r/158234/#review164254
Attachment #8887388 - Flags: review?(mshal) → review+

Comment 8

5 months ago
mozreview-review
Comment on attachment 8887389 [details]
Bug 1381770 - In tooltool-download.sh, only use the relengapi proxy when it's configured.

https://reviewboard.mozilla.org/r/158236/#review164258

::: taskcluster/scripts/misc/tooltool-download.sh:7
(Diff revision 1)
>  
>  cd $WORKSPACE/build/src
>  
> +TOOLTOOL_DL_FLAGS=
> +
> +if [ -n "$RELENGAPI_PORT" ]; then

Where does RELENGAPI_PORT get set? Would it make sense to pass in a TOOLTOOL_URL instead and set the --tooltool-url flag based on that?
Attachment #8887389 - Flags: review?(mshal) → review+

Comment 9

5 months ago
mozreview-review
Comment on attachment 8887390 [details]
Bug 1381770 - In tooltool-download.sh, automatically setup the relengapi authentication file.

https://reviewboard.mozilla.org/r/158238/#review164260
Attachment #8887390 - Flags: review?(mshal) → review+

Comment 10

5 months ago
mozreview-review
Comment on attachment 8887391 [details]
Bug 1381770 - Don't use the relengapi proxy for Linux toolchain jobs.

https://reviewboard.mozilla.org/r/158240/#review164262
Attachment #8887391 - Flags: review?(mshal) → review+
(Assignee)

Comment 11

5 months ago
(In reply to Michael Shal [:mshal] from comment #8)
> Comment on attachment 8887389 [details]
> Bug 1381770 - In tooltool-download.sh, only use the relengapi proxy when
> it's configured.
> 
> https://reviewboard.mozilla.org/r/158236/#review164258
> 
> ::: taskcluster/scripts/misc/tooltool-download.sh:7
> (Diff revision 1)
> >  
> >  cd $WORKSPACE/build/src
> >  
> > +TOOLTOOL_DL_FLAGS=
> > +
> > +if [ -n "$RELENGAPI_PORT" ]; then
> 
> Where does RELENGAPI_PORT get set? Would it make sense to pass in a
> TOOLTOOL_URL instead and set the --tooltool-url flag based on that?

It's set $somewhere when relengapi-proxy is enabled.

Comment 12

5 months ago
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/5dbf26e7d92d
Use $WORKSPACE instead of $HOME/workspace in tooltool-download.sh. r=mshal
https://hg.mozilla.org/integration/autoland/rev/688c2808b32c
Enable multiple download retries in tooltool-download.sh. r=mshal
https://hg.mozilla.org/integration/autoland/rev/ba2a0e45421b
In tooltool-download.sh, only use the relengapi proxy when it's configured. r=mshal
https://hg.mozilla.org/integration/autoland/rev/66bb1f3a35f9
In tooltool-download.sh, automatically setup the relengapi authentication file. r=mshal
https://hg.mozilla.org/integration/autoland/rev/a2ae5410cfd3
Don't use the relengapi proxy for Linux toolchain jobs. r=mshal
(Assignee)

Updated

5 months ago
Blocks: 1382564
https://hg.mozilla.org/mozilla-central/rev/5dbf26e7d92d
https://hg.mozilla.org/mozilla-central/rev/688c2808b32c
https://hg.mozilla.org/mozilla-central/rev/ba2a0e45421b
https://hg.mozilla.org/mozilla-central/rev/66bb1f3a35f9
https://hg.mozilla.org/mozilla-central/rev/a2ae5410cfd3
Status: NEW → RESOLVED
Last Resolved: 5 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.