Closed Bug 1381771 Opened 2 years ago Closed 2 years ago

fix mochitest-chrome failure in devtools/ when data: URI is unique origin.

Categories

(Core :: DOM: Security, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: allstars.chh, Assigned: allstars.chh)

Details

(Whiteboard: [domsecurity-active])

Attachments

(2 files, 1 obsolete file)

No description provided.
Priority: -- → P2
Attached patch Patch. (obsolete) — Splinter Review
Comment on attachment 8887811 [details] [diff] [review]
Patch.

Review of attachment 8887811 [details] [diff] [review]:
-----------------------------------------------------------------

::: devtools/shared/webconsole/test/test_commands_other.html
@@ +78,2 @@
>    info ("Waiting for content window to load");
> +  startTest();

Hi smaug
now I open a http page, the gWin.onload won't be called,
I guess this is because the gWin is not in the same origin(now test_commands_other.html is a chrome test)

However, even I try to do window.opener.postMessage in empty.html, it says "Permission denied to access property postMessage'

Do you have any suggestion to know that empty.html is loaded?

Thanks
Flags: needinfo?(bugs)
What is opener here? That kind of security exception sounds odd. Is opener a chrome window and window itself non-chrome window? I mean, what kind of principals they have?
Flags: needinfo?(bugs)
Hi pbro
I found you turn off r? flag for now, if you are too busy to review this, can you help to forward the r? to right one?

Thanks
Flags: needinfo?(pbrosset)
Comment on attachment 8888666 [details] [diff] [review]
Part 1: fix failures  in devtools/

Review of attachment 8888666 [details] [diff] [review]:
-----------------------------------------------------------------

I'm actually going away later today, I have already turned off review requests to avoid getting a big one I know I can't do in one day. But this is a small one, so I've done it now.
Thanks for working on this.
Attachment #8888666 - Flags: review+
Comment on attachment 8888667 [details] [diff] [review]
Part 2: use legacy data: URI behavior to run test.

Review of attachment 8888667 [details] [diff] [review]:
-----------------------------------------------------------------

Assigning this console-related one to bgrins.
Attachment #8888667 - Flags: review?(bgrinstead)
Flags: needinfo?(pbrosset)
Attachment #8888667 - Flags: review?(bgrinstead) → review+
Pushed by yhuang@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/83e350c46e94
Part 1: fix mc1 failures in devtools/ when data: URI is unique origin. r=pbro
https://hg.mozilla.org/integration/mozilla-inbound/rev/1f551cfb7a2d
Part 2: use legacy data: URI behavior to run test. r=bgrins
https://hg.mozilla.org/mozilla-central/rev/83e350c46e94
https://hg.mozilla.org/mozilla-central/rev/1f551cfb7a2d
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.