Closed Bug 1381833 Opened 7 years ago Closed 7 years ago

Port bug 1279717 to TB [introduce a Color.jsm module that implements common color math operations in a single place]

Categories

(Thunderbird :: General, enhancement)

Product:
Thunderbird
Component:
General
Platform:
All
Windows
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird 56.0

People

(Reporter: Paenglab, Assigned: Paenglab)

Details

Attachments

(1 file)

color.jsm.patch
3.24 KB, patch
jorgk-bmo
: review+
Details | Diff | Splinter Review 
On reading bug 1379266 I saw, we haven't followed bug 1279717. Using Color.jsm lets us get changes in it without need to change our code.
Attached patch color.jsm.patch — — Splinter Review 
This change is only checkable on Win8. I tried it on my VM and it worked as before.
Assignee: nobody → richard.marti
Status: NEW → ASSIGNED
Attachment #8887479 - Flags: review?(jorgk)
Ah forgot, the M-C change begins here: https://hg.mozilla.org/mozilla-central/rev/aa3e5b818a71#l1.1
Comment on attachment 8887479 [details] [diff] [review]
color.jsm.patch

Looks good upon visual inspection.
Attachment #8887479 - Flags: review?(jorgk) → review+
Keywords: checkin-needed
https://hg.mozilla.org/comm-central/rev/36c79355c7779d7198aa242e94f58738b6e467ca
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: checkin-needed
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 56.0
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: