Stop clearing WebRenderPaintedBlob layers when intializing the record DT

RESOLVED WORKSFORME

Status

()

Core
Graphics: WebRender
RESOLVED WORKSFORME
6 months ago
2 months ago

People

(Reporter: mchang, Assigned: mchang)

Tracking

(Blocks: 1 bug)

unspecified
Points:
---

Firefox Tracking Flags

(firefox57 unaffected)

Details

(Whiteboard: [gfx-noted])

Attachments

(1 attachment)

(Assignee)

Description

6 months ago
Created attachment 8887504 [details] [diff] [review]
Don't clear WebRenderPaintedBlobLayer

From https://bugzilla.mozilla.org/show_bug.cgi?id=1379322#c2

Try WR looks good - https://treeherder.mozilla.org/#/jobs?repo=try&revision=a22d5aefc6ac43105c9380f80d540c3ec4f9fb81

Just hope WR is handling this correctly. ContentClient clears the buffer for us as needed to the right color, hence OMTP clearing it again was bad. WR needs something to clear the buffer to the right color as well then.
Attachment #8887504 - Flags: review?(jmuizelaar)
We initialize to opaque white. For this to be valid we need to switch this to transparent black: http://searchfox.org/mozilla-central/source/gfx/webrender_bindings/src/moz2d_renderer.rs#57
status-firefox57: --- → unaffected
Component: Graphics → Graphics: WebRender
Priority: -- → P3
Whiteboard: [gfx-noted]
Blocks: 1386665

Updated

4 months ago
Whiteboard: [gfx-noted] → [wr-mvp] [triage] [gfx-noted]

Updated

4 months ago
Status: NEW → ASSIGNED
Priority: P3 → P1
Whiteboard: [wr-mvp] [triage] [gfx-noted] → [wr-mvp] [gfx-noted]
Target Milestone: --- → mozilla57
(Assignee)

Updated

4 months ago
Assignee: mchang → nobody
Status: ASSIGNED → NEW

Updated

4 months ago
Priority: P1 → P2
Target Milestone: mozilla57 → ---
Attachment #8887504 - Flags: review?(jmuizelaar)
We don't have this extra clear in layers free.
Status: NEW → RESOLVED
Last Resolved: 3 months ago
Resolution: --- → FIXED

Updated

3 months ago
Priority: P2 → --
Resolution: FIXED → WORKSFORME
Whiteboard: [wr-mvp] [gfx-noted] → [gfx-noted]
Assignee: nobody → mchang
You need to log in before you can comment on or make changes to this bug.