Review and eventually simplify the various .properties files used for key shortcuts and menuitems

NEW
Unassigned

Status

()

Firefox
Developer Tools
P3
normal
7 months ago
5 months ago

People

(Reporter: ochameau, Unassigned)

Tracking

unspecified
Points:
---

Firefox Tracking Flags

(firefox57 fix-optional)

Details

(Reporter)

Description

7 months ago
After bug 1359855, registering a new tool is going to require contributing to two .properties files in devtools/client/locales/en-US/:
* key-shortcuts.properties
Contains command-key, i.e. the key code for each tool, used for registering all key shortcuts early during Firefox startup.

* startup.properties
Contains label and accesskey, used to display one menu item for each tool in the "Web Developer" system menu, as well as to display the tool title in the toobox tabs.

Also note that menus.properties is similar to startup.properties.
It allows registering menu items in the "Web developer" system menu, but for everything that is not a panel in the toolbox. Like WebIDE, scratchpad, about:debugging, ...

The complexity may come from devtools/client/framework/browser-menus
which has to have distinct codepaths for menus related to panels (inspector, console, ...) and menus related to global tools (about:debugging, scratchpad, ...).

What about merging startup.properties and menus.properties so that all menu definitions, including label and accesskey are in one place, no matter if the tool is in toolbox or not?
We could also try to merge also with key-shortcuts.properties, but it would mean loading strings that are not useful early during Firefox startup.
Priority: -- → P3
status-firefox57: --- → fix-optional
You need to log in before you can comment on or make changes to this bug.