Closed
Bug 1381891
Opened 6 years ago
Closed 6 years ago
Inline IsTypedArray when TypedArray and non-TypedArrays were observed
Categories
(Core :: JavaScript Engine: JIT, enhancement)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: anba, Assigned: anba)
References
Details
Attachments
(1 file)
12.48 KB,
patch
|
jandem
:
review+
|
Details | Diff | Splinter Review |
Improves this benchmark from 660ms to 380ms for me var a = Array(100).fill(0).map((v, k) => k + 1); var ta = new Int32Array(100).map((v, k) => k + 1); var q = 0; var t = Date.now(); for (var i = 0; i < 100000; ++i) { for (var x of a) q += x; for (var x of ta) q += x; } print(Date.now() - t, q);
Assignee | ||
Updated•6 years ago
|
Assignee: nobody → andrebargull
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•6 years ago
|
||
Is possible to inline IsTypedArray using approach?
Attachment #8887544 -
Flags: review?(jdemooij)
Comment 3•6 years ago
|
||
Comment on attachment 8887544 [details] [diff] [review] bug1381891.patch Review of attachment 8887544 [details] [diff] [review]: ----------------------------------------------------------------- LGTM!
Attachment #8887544 -
Flags: review?(jdemooij) → review+
Assignee | ||
Comment 4•6 years ago
|
||
Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e8205552dde4b51b48d200286e9b666a2e82e32a
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/8e46fc907da9 Inline IsTypedArray even when non-TypedArrays were observed. r=jandem
Keywords: checkin-needed
![]() |
||
Comment 6•6 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/8e46fc907da9
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•