1381891 - Inline IsTypedArray when TypedArray and non-TypedArrays were observed

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement)

Description

[André Bargull [:anba]]

Improves this benchmark from 660ms to 380ms for me

    var a = Array(100).fill(0).map((v, k) => k + 1);
    var ta = new Int32Array(100).map((v, k) => k + 1);
    var q = 0;
    var t = Date.now();
    for (var i = 0; i < 100000; ++i) {
        for (var x of a) q += x;
        for (var x of ta) q += x;
    }
    print(Date.now() - t, q);

Comment 1

[André Bargull [:anba]]

Attachment: bug1381891.patch

Is possible to inline IsTypedArray using approach?

Comment 3

[Jan de Mooij [:jandem]]

Comment on attachment 8887544 [details] [diff] [review]
bug1381891.patch

Review of attachment 8887544 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM!

Comment 4

[André Bargull [:anba]]

Try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=e8205552dde4b51b48d200286e9b666a2e82e32a

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/8e46fc907da9
Inline IsTypedArray even when non-TypedArrays were observed. r=jandem

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/8e46fc907da9