Viewing subtests never loads

RESOLVED FIXED

Status

Tree Management
Perfherder
RESOLVED FIXED
a year ago
11 months ago

People

(Reporter: erahm, Assigned: wlach)

Tracking

Details

Attachments

(2 attachments)

Created attachment 8887559 [details]
Web console error

I often get an infinite cat-head-nodding when trying to load the subtests for a regressed AWSY test. Shift-reloading fixes things, so I'm assuming there's some kind of backend timeout that's not communicated. Attached is a rather obfuscated error from the web console.

STR:

- Find an old awsy regression
- Choose a platform
- Click subtests
There is a race in Perfherder's compare view. jdm noticed it too with this url:

https://treeherder.mozilla.org/perf.html#/comparesubtest?originalProject=mozilla-central&originalRevision=5d794bf4c4653153e602631f1b8818acd559d8f5&newProject=mozilla-central&newRevision=efc0b1525edbd357818dc7195537364e76f709e7&originalSignature=dd55da63ebce86ee3867aa3b39975c2a90869ce2&newSignature=dd55da63ebce86ee3867aa3b39975c2a90869ce2&framework=1

Going to try to do up a fix asap. The spaghetti code in the compare view really needs a rewrite so that problems like this don't sneak in. :(
Assignee: nobody → wlachance
Created attachment 8887666 [details] [review]
[treeherder] wlach:1381904 > mozilla:master
Comment on attachment 8887666 [details] [review]
[treeherder] wlach:1381904 > mozilla:master

We really need to clean up this code one of these days but this should at least fix the problem at hand.
Attachment #8887666 - Flags: review?(shrutijasoria1996)
Comment on attachment 8887666 [details] [review]
[treeherder] wlach:1381904 > mozilla:master

Once I'm done with the GSoC project, I'll start cleaning up this code.
Attachment #8887666 - Flags: review?(shrutijasoria1996) → review+

Comment 6

a year ago
Commit pushed to master at https://github.com/mozilla/treeherder

https://github.com/mozilla/treeherder/commit/812eb503b87f84604d81296390fe0b96bb69e9e0
Bug 1381904 - Fix race condition when verifying revisions in perfherder compare (#2641)
Status: NEW → RESOLVED
Last Resolved: 11 months ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.