1381915 - Upgrade in-tree version of voluptuous

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Chris AtLee [:catlee]]

We have 0.8.11 in-tree. Latest version on pypi is 0.10.5.

This speeds up task generation on my system.

Before:
time ./mach taskgraph target -p parameters.yml
26.38s user 0.19s system 99% cpu 26.594 total

After:
time ./mach taskgraph target -p parameters.yml
11.42s user 0.17s system 99% cpu 11.672 total

Comment 1

[Chris AtLee [:catlee]]

Attachment: Bug 1381915: upgrade voluptuous to 0.10.5

Review commit: https://reviewboard.mozilla.org/r/158428/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/158428/

Comment 2

[Chris AtLee [:catlee]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d42c529d6bd8

Comment 3

[Andrew Halberstadt [:ahal]]

This looks good to me, but dustin should give this the final ok.

Comment 4

[Andrew Halberstadt [:ahal]]

Comment on attachment 8887565 [details]
Bug 1381915: upgrade voluptuous to 0.10.5

https://reviewboard.mozilla.org/r/158428/#review163820

::: third_party/python/voluptuous/CHANGELOG.md:1
(Diff revision 1)
> +# Changelog
> +
> +## [Unreleased]
> +
> +## [0.10.5]
> +
> +- [#278](https://github.com/alecthomas/voluptuous/pull/278): Unicode
> +translation to python 2 issue fixed.
> +
> +## [0.10.2]
> +
> +**Changes**:

Actually, I think gps usually insists on checking the unzipped wheels. I think you can do this with:

    $ pip install wheel
    $ pip wheel voluptuous
    $ unzip voluptuous-0.10.5-py2-none-any.whl

Then add the files in the resulting "voluptuous" folder. That way we don't have to include all this changelog/package cruft.

I filed bug 1346026 awhile back to add some sort of automatic vendoring mechanism.

Comment 5

[Dustin J. Mitchell [:dustin] (he/him)]

Comment on attachment 8887565 [details]
Bug 1381915: upgrade voluptuous to 0.10.5

https://reviewboard.mozilla.org/r/158428/#review163822

I had *some* reason for not using the latest voluptuous.  I remember being concerned that 0.8.x was one file, whereas later versions were a bunch of Python packages, but it's not like it's MB's of code.  Maybe there was some bug in the latest version that is now fixed?  I don't remember :(

Anyway, since this works now and is faster to boot, let's do it!

Comment 6

[Chris AtLee [:catlee]]

Comment on attachment 8887565 [details]
Bug 1381915: upgrade voluptuous to 0.10.5

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/158428/diff/1-2/

Comment 7

[Andrew Halberstadt [:ahal]]

Comment on attachment 8887565 [details]
Bug 1381915: upgrade voluptuous to 0.10.5

https://reviewboard.mozilla.org/r/158428/#review164114

Thanks!

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c783e87dc7fd
upgrade voluptuous to 0.10.5 r=ahal,dustin

Comment 9

[Gregory Szorc [:gps]]

Yes, we don't like checking in wheels because they are opaque. .whl files are just zip files. So you can unzip them and vendor. Or you can clone the underlying repo they came from and copy files from a specific commit.

Comment 10

[Gregory Szorc [:gps]]

This change may cause issues due to a cached voluptuous.pyc file. Source directory clobbers (mach clobber python) may be required.

Comment 11

[Gregory Szorc [:gps]]

Come to think of it, I think glandium coded up some Python importer magic a while back to verify the .py file exists before attempting to use a .pyc. So I think we may be good.

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/c783e87dc7fd