Closed Bug 1381924 Opened 2 years ago Closed 2 years ago

[geckoview] Include WebRTC files and perms for GeckoView

Categories

(GeckoView :: General, enhancement)

Unspecified
Android
enhancement
Not set

Tracking

(firefox56 fixed)

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: jchen, Assigned: jchen)

References

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8887625 [details]
Bug 1381924 - Include WebRTC bits for GeckoView;

https://reviewboard.mozilla.org/r/158504/#review163768

I'm fine with this, but I'm concerned that there aren't `geckoview_example` changes or tests to exercise this functionality.  How do you know this works?

::: mobile/android/geckoview/src/main/AndroidManifest.xml:29
(Diff revision 1)
> -
>      <uses-permission android:name="android.permission.CAMERA" />
>      <uses-feature android:name="android.hardware.camera" android:required="false"/>
>      <uses-feature android:name="android.hardware.camera.autofocus" android:required="false"/>
>  
> +    <!--#ifdef MOZ_WEBRTC-->

Consider adding your comment about preprocessing here.  We can (eventually) make this conditional, but it's easier not to.
Attachment #8887625 - Flags: review?(nalexander) → review+
Once bug 1322586 lands, WebRTC should work out of the box in geckoview_example (non-e10s), but yeah it'd be nice to have tests.
Pushed by nchen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/aa10d1423912
Include WebRTC bits for GeckoView; r=nalexander
https://hg.mozilla.org/mozilla-central/rev/aa10d1423912
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Product: Firefox for Android → GeckoView
Target Milestone: Firefox 56 → mozilla56
You need to log in before you can comment on or make changes to this bug.