Closed Bug 1381924 Opened 2 years ago Closed 2 years ago
[geckoview] Include Web
RTC files and perms for Gecko View
No description provided.
Comment on attachment 8887625 [details] Bug 1381924 - Include WebRTC bits for GeckoView; https://reviewboard.mozilla.org/r/158504/#review163768 I'm fine with this, but I'm concerned that there aren't `geckoview_example` changes or tests to exercise this functionality. How do you know this works? ::: mobile/android/geckoview/src/main/AndroidManifest.xml:29 (Diff revision 1) > - > <uses-permission android:name="android.permission.CAMERA" /> > <uses-feature android:name="android.hardware.camera" android:required="false"/> > <uses-feature android:name="android.hardware.camera.autofocus" android:required="false"/> > > + <!--#ifdef MOZ_WEBRTC--> Consider adding your comment about preprocessing here. We can (eventually) make this conditional, but it's easier not to.
Attachment #8887625 - Flags: review?(nalexander) → review+
Once bug 1322586 lands, WebRTC should work out of the box in geckoview_example (non-e10s), but yeah it'd be nice to have tests.
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/aa10d1423912 Include WebRTC bits for GeckoView; r=nalexander
You need to log in before you can comment on or make changes to this bug.