Small JitFrameIterator refactorings

RESOLVED FIXED in Firefox 56

Status

()

Core
JavaScript Engine: JIT
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: bbouvier, Assigned: bbouvier)

Tracking

Trunk
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(2 attachments)

(Assignee)

Description

9 months ago
Three things have bugged me enough that I wanted to open a bug about them:
- all the non-trivial JitFrameIterator ctors do basically the same thing
- the JitFrameIterator impl is in JitFrames.cpp, while there's a JitFrameIterator{,-inl}.h.
- some inline JitFrameIterator methods are defined in JitFrames-inl.h
(Assignee)

Comment 1

9 months ago
Created attachment 8887581 [details] [diff] [review]
1.delegate.patch

Simple trick: delegate ctors to a private ctor that does the right thing to the most common denominator.
Assignee: nobody → bbouvier
Status: NEW → ASSIGNED
Attachment #8887581 - Flags: review?(nicolas.b.pierron)
(Assignee)

Comment 2

9 months ago
Created attachment 8887582 [details] [diff] [review]
2.codemotion.patch

Just code motion:
- JitFrameIterator methods are moved from JitFrames.cpp to JitFrameIterator.cpp
- some JitFrameIterator inline methods are moved from JitFrames-inl.h to JitFrameIterator-inl.h

This passes make check-style and non-unified build on x64, let's see what try says: https://treeherder.mozilla.org/#/jobs?repo=try&revision=6b2aaf74414cfe0760a704cb1995a0b6cf6b5f7e
Attachment #8887582 - Flags: review?(nicolas.b.pierron)
Attachment #8887581 - Flags: review?(nicolas.b.pierron) → review+
Attachment #8887582 - Flags: review?(nicolas.b.pierron) → review+

Comment 3

9 months ago
Pushed by bbouvier@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/33cf2dcc5aaf
Use delegating ctors for JitFrameIterator; r=nbp
https://hg.mozilla.org/integration/mozilla-inbound/rev/f15bf893f71f
Move JitFrameIterator methods to their own cpp file; r=nbp

Comment 4

9 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/33cf2dcc5aaf
https://hg.mozilla.org/mozilla-central/rev/f15bf893f71f
Status: ASSIGNED → RESOLVED
Last Resolved: 9 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.