Closed Bug 1381953 Opened 3 years ago Closed 3 years ago

Enable new preferences for Firefox 56

Categories

(Firefox :: Preferences, enhancement, P2)

enhancement

Tracking

()

VERIFIED FIXED
Firefox 56
Tracking Status
firefox56 --- fixed
firefox57 --- verified

People

(Reporter: jaws, Assigned: jaws)

References

Details

(Whiteboard: [photon-preference])

Attachments

(1 file)

Currently the new preferences are only enabled by default in Nightly builds[1]. We will need to change this if we ship the new re-org + search in 56.

@timdream, can you verify that this is the plan and coordinate with the team to make sure this gets fixed?

[1] http://searchfox.org/mozilla-central/rev/88180977d79654af025158d8ebeb8c2aa11940eb/browser/app/profile/firefox.js#732-737
Flags: needinfo?(timdream)
Yes! The intention is to have the new Preferences along with search to ride the 56 train. Let's turn it on once we get a mid-Nightly sign-off from QE.
Flags: needinfo?(timdream)
Priority: -- → P2
QA Contact: hani.yacoub
Whiteboard: [photon-preference]
Target Milestone: --- → Firefox 56
We're basically a day away from 56 merging to Beta (Wednesday morning). This needs to be done ASAP.
Assignee: nobody → jaws
Status: NEW → ASSIGNED
Comment on attachment 8892208 [details]
Bug 1381953 - Enable the new preferences organization for Firefox 56.

https://reviewboard.mozilla.org/r/163152/#review168496
Attachment #8892208 - Flags: review?(mconley) → review+
\o/ Let's put the spaghetti in the machine!
FYI, just to comment in the bug. We received a sign-off from QE on July 7th.

Snippet from their email...

ABOUT:PREFERENCES REVAMP

Feature sign off report, Manual QA
Target GA: Firefox 56 - September 26, 2017.
Sign off phase: mid-Nightly (Fx56).

MANUAL QA'S ASSESSMENT & RECOMMENDATION
Feature status: GREEN.

    Reason: 30% of our tests failed, but none of them with major issues.

Recommendation: SHIP IT

    Reason: 2 new issues were uncovered during testing (1378783, 1378366), but are minor issues and are reproducible also on Firefox 54.0.1 RC and Firefox 55 so aren't necessarily related to this feature. 
    Proposed course of action: Fix these issues in order to improve this features health status before the merge to beta.
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/527790e669cf
Enable the new preferences organization for Firefox 56. r=mconley
Filed bug 1386051 to track removing support for browser.preferences.useOldOrganization.
Flags: needinfo?(jaws)
Pushed by jwein@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/67c9b30390e7
Enable the new preferences organization for Firefox 56. r=mconley
https://hg.mozilla.org/mozilla-central/rev/67c9b30390e7
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Build ID: 20170816100153
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

Verified as fixed on Firefox Nightly 57.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.