1381953 - Enable new preferences for Firefox 56

Status: VERIFIED FIXED

(Firefox :: Settings UI, enhancement, P2)

Description

[Jared Wein [:jaws] (please needinfo? me)]

Currently the new preferences are only enabled by default in Nightly builds[1]. We will need to change this if we ship the new re-org + search in 56.

@timdream, can you verify that this is the plan and coordinate with the team to make sure this gets fixed?

[1] http://searchfox.org/mozilla-central/rev/88180977d79654af025158d8ebeb8c2aa11940eb/browser/app/profile/firefox.js#732-737

Comment 1

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Yes! The intention is to have the new Preferences along with search to ride the 56 train. Let's turn it on once we get a mid-Nightly sign-off from QE.

Comment 2

[Ryan VanderMeulen [:RyanVM]]

We're basically a day away from 56 merging to Beta (Wednesday morning). This needs to be done ASAP.

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Attachment: Bug 1381953 - Enable the new preferences organization for Firefox 56.

Support for browser.preferences.useOldOrganization will be removed later towards the end of the 56 beta cycle when we are sure that there are no late-breaking issues that will cause us to hold back on shipping the new preferences.

Review commit: https://reviewboard.mozilla.org/r/163152/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/163152/

Comment 4

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8892208 [details]
Bug 1381953 - Enable the new preferences organization for Firefox 56.

https://reviewboard.mozilla.org/r/163152/#review168496

Comment 5

[Mike Conley (:mconley) (:⚙️)]

\o/ Let's put the spaghetti in the machine!

Comment 6

[Jared Wein [:jaws] (please needinfo? me)]

FYI, just to comment in the bug. We received a sign-off from QE on July 7th.

Snippet from their email...

ABOUT:PREFERENCES REVAMP

Feature sign off report, Manual QA
Target GA: Firefox 56 - September 26, 2017.
Sign off phase: mid-Nightly (Fx56).

MANUAL QA'S ASSESSMENT & RECOMMENDATION
Feature status: GREEN.

    Reason: 30% of our tests failed, but none of them with major issues.

Recommendation: SHIP IT

    Reason: 2 new issues were uncovered during testing (1378783, 1378366), but are minor issues and are reproducible also on Firefox 54.0.1 RC and Firefox 55 so aren't necessarily related to this feature. 
    Proposed course of action: Fix these issues in order to improve this features health status before the merge to beta.

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/527790e669cf
Enable the new preferences organization for Firefox 56. r=mconley

Comment 8

[Jared Wein [:jaws] (please needinfo? me)]

Filed bug 1386051 to track removing support for browser.preferences.useOldOrganization.

Comment 9

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out in https://hg.mozilla.org/integration/autoland/rev/91ab8093a2d4729f64b5af05f633f659ac8a3cc4 for failures like https://treeherder.mozilla.org/logviewer.html#?job_id=119788608&repo=autoland

Comment 10

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8892208 [details]
Bug 1381953 - Enable the new preferences organization for Firefox 56.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/163152/diff/1-2/

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/67c9b30390e7
Enable the new preferences organization for Firefox 56. r=mconley

Comment 12

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/67c9b30390e7

Comment 13

[Hani Yacoub, Desktop QA]

Build ID: 20170816100153
User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:57.0) Gecko/20100101 Firefox/57.0

Verified as fixed on Firefox Nightly 57.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.