Closed Bug 1382002 Opened 9 years ago Closed 9 years ago

Use scalar for activeTicks column if possible

Categories

(Data Platform and Tools :: General, enhancement, P1)

enhancement
Points:
2

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: bugzilla, Assigned: vgutierrez5)

References

Details

With the addition of activeTicks as a scalar value (Bug 1376942), we should try to get that value from the scalar first and fall back to simpleMeasures if the scalar value doesn't exist. This will allow us to remove the value from simpleMeasures entirely in the client.
(In reply to Sunah Suh (she/her) [:sunahsuh] from comment #0) > With the addition of activeTicks as a scalar value (Bug 1376942), we should > try to get that value from the scalar first and fall back to simpleMeasures > if the scalar value doesn't exist. This will allow us to remove the value > from simpleMeasures entirely in the client. Right now, `activeTicks` will automatically be added as a scalar starting with tonights build. Thoughts on leaving everything as-is, and let the value be `null` when missing? People could just do a `coalesce` in their queries to get the non-null field.
> People could just do a `coalesce` in their queries to get the non-null field. This is an unreasonable expectation for everyone who uses this data to keep in mind/know to do for years into the future (because that's probably how long it'll take to get to enough clients upgraded past 56), especially since we're planning to do several of these migrations. I *am* concerned about the auto-added scalar value giving future users the misleading idea that this is where they should look for activeTicks and am working on a proposal to mitigate this in one go, probably near the end of the internship.
(In reply to Sunah Suh (she/her) [:sunahsuh] from comment #2) > I *am* concerned about the auto-added scalar value giving future users the > misleading idea that this is where they should look for activeTicks and am > working on a proposal to mitigate this in one go, probably near the end of > the internship. I see your hesitation. In that case we should consider blacklisting those scalars when changing this current column.
Points: --- → 2
Priority: -- → P1
(In reply to Mark Reid [:mreid] from comment #4) > See https://github.com/mozilla/telemetry-batch-view/pull/286 There's an active-ticks specific pull request that was merged: https://github.com/mozilla/telemetry-batch-view/pull/282
Excellent, can we close this bug?
Flags: needinfo?(vgutierrez)
(In reply to Mark Reid [:mreid] from comment #6) > Excellent, can we close this bug? I think so, to be safe can :sunahsuh confirm?
Flags: needinfo?(vgutierrez) → needinfo?(ssuh)
Go for it! :)
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Flags: needinfo?(ssuh)
Component: Datasets: Main Summary → General
You need to log in before you can comment on or make changes to this bug.