1382023 - Pull some irregexp patches.

Status: RESOLVED FIXED

(Core :: JavaScript Engine: JIT, enhancement)

Description

[Sean Stangl [:sstangl]]

Attachment: 0001-Fold-repeated-assertions.patch

At the All-Hands, there was some talk of staying more current with v8's irregexp, since we haven't pulled from upstream in many years, and we made stylistic changes that make importation difficult.

Most of the changes to v8's irregexp have been for Latin1 and Unicode support. There have been some small changes that affect performance, that integrate well with our old version.

These changes are probably too small to affect anything, but regexp has been showing up on some Speedometer profiles for me, and so I want to normalize things as much as I can.

Chromium review links are in each patch's description.

Comment 1

[Sean Stangl [:sstangl]]

Attachment: 0002-Optimize-better-in-presence-of-lookaround.patch

Comment 2

[Jan de Mooij [:jandem]]

Comment on attachment 8887686 [details] [diff] [review]
0001-Fold-repeated-assertions.patch

Review of attachment 8887686 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense, thanks for doing this.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fef3121e0dd2
Fold repeated assertions. r=jandem
https://hg.mozilla.org/integration/mozilla-inbound/rev/762b5a6fe669
Optimize better in presence of lookaround. r=jandem

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/fef3121e0dd2
https://hg.mozilla.org/mozilla-central/rev/762b5a6fe669