Closed Bug 1382044 Opened 3 years ago Closed 3 years ago

Disable validation in middle phases of TPS test_addon_nonrestartless_xpi.js that fails in automation

Categories

(Firefox :: Sync, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
Firefox 56
Tracking Status
firefox56 --- fixed

People

(Reporter: tcsc, Assigned: tcsc)

References

Details

Attachments

(1 file)

Required to keep TPS useful instead of failing constantly.

Patch incoming
Comment on attachment 8887716 [details]
Bug 1382044 - Disable addon validation during some phases of TPS's test_addon_nonrestartless_xpi.js.

https://reviewboard.mozilla.org/r/158620/#review163896

Thanks!

::: services/sync/tests/tps/test_addon_nonrestartless_xpi.js:53
(Diff revision 1)
>  // Now we disable the add-on
>  Phase("phase05", [
>    [EnsureTracking],
>    [Addons.setEnabled, [id], STATE_DISABLED],
> -  [Sync]
> +  [Sync],
> +  [Addons.skipValidation]

Can you please add a comment to each of these new lines, something like "validation disabled due to bug 
1380472"
Attachment #8887716 - Flags: review?(markh) → review+
Pushed by tchiovoloni@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a6b254ae6569
Disable addon validation during some phases of TPS's test_addon_nonrestartless_xpi.js. r=markh
https://hg.mozilla.org/mozilla-central/rev/a6b254ae6569
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
See Also: → 1427835
You need to log in before you can comment on or make changes to this bug.