Closed Bug 1382081 Opened 2 years ago Closed 2 years ago

Notify API 15 user EOL

Categories

(Firefox for Android :: General, defect)

All
Android
defect
Not set

Tracking

()

VERIFIED FIXED
Firefox 56
Tracking Status
firefox55 blocking fixed
firefox56 + fixed

People

(Reporter: maliu, Assigned: maliu)

References

Details

Attachments

(2 files)

Notify affected user EOL of fennec and bump minsdk in next release.
Assignee: nobody → max
Attachment #8887753 - Flags: review?(s.kaspari)
Why is this bug confidential?
Comment on attachment 8887753 [details] [diff] [review]
Notify EOL to affected user

Review of attachment 8887753 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM.

Note that this only needs to land in Beta.
Attachment #8887753 - Flags: review?(s.kaspari) → review+
Can we open this bug? I don't think we want it to be confidential - the point is to let users know. 

From email discussion, sounds like we're aiming this at Firefox 56.
*waves magic wand*
Group: mozilla-employee-confidential
Keywords: checkin-needed
I guess we need to request uplift here?
Flags: needinfo?(max)
QA Contact: ioana.chiorean
(In reply to Sebastian Kaspari (:sebastian) from comment #7)
> I guess we need to request uplift here?

I guess we're not uplift this to 55 because Andreas agrees to bump in 57.
Flags: needinfo?(max)
https://hg.mozilla.org/mozilla-central/rev/3db31de3ac85
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
According to bug 1316462 comment 55 and bug 1379190 we ripped out some media APIs in 56 already. Are we sure we do not want to show the EOL messaging in 55 and remove support in 56?
Flags: needinfo?(max)
Flags: needinfo?(abovens)
Can you clarify how these media APIs relate to dropping ICS support in more detail? I'm not sure I fully understand the dependency.
Flags: needinfo?(abovens) → needinfo?(s.kaspari)
It looks like we already removed some media code that was specifically used on API 15 in v56 (bug 1379190). However I'm not sure what exactly this means for the state of v56 on API 15 devices.

:jya: What exactly does the code removal in bug 1379190 mean for API 15 devices? Does this mean we *have to* end support of API in 56?
Flags: needinfo?(s.kaspari) → needinfo?(jyavenard)
It means we can no longer play any H264, MP3 or Aac media files (That is most media files out there)
Flags: needinfo?(jyavenard)
OK, thanks for the clarification. Looking into what can be done.
(In reply to Sebastian Kaspari (:sebastian) from comment #10)
> According to bug 1316462 comment 55 and bug 1379190 we ripped out some media
> APIs in 56 already. Are we sure we do not want to show the EOL messaging in
> 55 and remove support in 56?

I do hope we can uplift this to 55 and safely land Bug 1379190 at 56. However, Bug 1379190 already landed and not following the dependency, I hope this won't be the reason for rel-mgr to force uplift this patch to 55.
Flags: needinfo?(max)
Comment on attachment 8887753 [details] [diff] [review]
Notify EOL to affected user

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1316462
[User impact if declined]: User will not receive any update, and without notification.
[Is this code covered by automated tests?]: No
[Has the fix been verified in Nightly?]: No
[Needs manual test from QE? If yes, steps to reproduce]:  Yes, have a ICS device install with this version, first launch will have a notification redirect user to a SUMO page.
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No
[Why is the change risky/not risky?]: Only popup a notification to system and not touching any other component.
[String changes made/needed]: N/A
Attachment #8887753 - Flags: approval-mozilla-beta?
Comment on attachment 8887753 [details] [diff] [review]
Notify EOL to affected user

eol notification for android 4.0 users, should be in 55.0b14 as API 15 support is being removed in 56
Attachment #8887753 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Attached image Screenshots
Devices used: 
- ZTE Grand X In - Android 4.0.4 - x86 architecture
- HTC Sensations 4G - Android 4.0.4

We get a notification in the Android Notif Bar and tapping it will load the SuMO page https://support.mozilla.org/en-US/kb/firefox-no-longer-supported-this-version-android?redirectlocale=en-US&as=u&redirectslug=unsupported-version&utm_source=inproduct

I used the taskcluster builds so I will want to try it at updates from Beta 12 to 14 next Tuesda also. 
But atm all looks fine.
As per previous comment
Status: RESOLVED → VERIFIED
fwiw, I'm concerned a user may not receive the notification because they're fairly easy to accidentally dismiss, examples:
- notification is shown but user restarts device
- user accidentally clears all notifications
- user accidentally swipes away the wrong notification

I would prefer to do a dialog or alert badge in product, which are more difficult to accidentally mis-use.

It looks like this is pre-existing code and we may have done this style of EOL before but it's something to consider for something so serious (i.e. "You will no longer get security updates").
You need to log in before you can comment on or make changes to this bug.