Closed Bug 1382095 Opened 3 years ago Closed 3 years ago

Mainthread-refcounts on MediaEngineSource in setLastPrefs runnable can sidestep proper cleanup on shutdown.

Categories

(Core :: WebRTC: Audio/Video, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: jib, Assigned: jib)

References

Details

Attachments

(2 files)

May be a potential cause of crashes like bug 1374164.

I have a patch to avoid ref-counting MediaEngineSource itself in setLastPrefs runnables to improve shutdown (see bug 1374164 comment 11), that I'll add here.
Comment on attachment 8887764 [details]
Bug 1382095 - Fix Refcountable<> helper to avoid size mismatch in the memory leak logging table.

https://reviewboard.mozilla.org/r/158682/#review164464
Attachment #8887764 - Flags: review?(rjesup) → review+
Comment on attachment 8887763 [details]
Bug 1382095 - Avoid ref-counting MediaEngineSource itself in setLastPrefs runnables to improve shutdown.

https://reviewboard.mozilla.org/r/158680/#review164466
Attachment #8887763 - Flags: review?(rjesup) → review+
Pushed by jbruaroey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/58e5ecbd98b3
Avoid ref-counting MediaEngineSource itself in setLastPrefs runnables to improve shutdown. r=jesup
https://hg.mozilla.org/integration/autoland/rev/5a82cec96940
Fix Refcountable<> helper to avoid size mismatch in the memory leak logging table. r=jesup
https://hg.mozilla.org/mozilla-central/rev/58e5ecbd98b3
https://hg.mozilla.org/mozilla-central/rev/5a82cec96940
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.