Closed Bug 1382130 Opened 3 years ago Closed 3 years ago

Build Stylo for linux64 ASAN builds

Categories

(Core :: CSS Parsing and Computation, defect, P2)

defect

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox54 --- wontfix
firefox55 --- wontfix
firefox56 --- fixed

People

(Reporter: cpeterson, Assigned: cpeterson)

References

(Blocks 1 open bug)

Details

Attachments

(1 file)

Bug 1374824 added `ac_add_options --enable-stylo=build` to automation's linux64/common-opt and linux64/debug mozconfig files, but the linux64 ASAN builds used for fuzzing have their own separate mozconfig files:

http://searchfox.org/mozilla-central/source/browser/config/mozconfigs/linux64/nightly-asan
http://searchfox.org/mozilla-central/source/browser/config/mozconfigs/linux64/nightly-fuzzing-asan
This Try run is probably not going to work because fuzzing enables Valgrind and the linux64/valgrind mozconfig says Rust code causes Valgrind false positives (bug 1365915).

https://treeherder.mozilla.org/#/jobs?repo=try&revision=debe59dd8ef29560409a4a011a6c5c0fade56676
Depends on: 1365915
Attachment #8887816 - Flags: review?(gps)
The test runs for the linux64-asan did not totally blow up. Jesse says he doesn't know why the asan mozconfigs --enable-valgrind. The risk from my proposed mozconfig change is low because it would only affect the fuzzing builds.
Comment on attachment 8887816 [details]
Bug 1382130 - Build Stylo for linux64 ASAN builds.

https://reviewboard.mozilla.org/r/158728/#review164314

This seems reasonable assuming automation is happy.

Also, --enable-style=build only builds stylo, it doesn't enable it. I doubt that will achieve much more additional test coverage unless stylo is being enabled at run time. But if you enable stylo by default, you'll lose some coverage for non-stylo, which is the current build default. So the correct solution is to fuzz with style enabled and disabled until we drop the non-stylo system.
Attachment #8887816 - Flags: review?(gps) → review+
(In reply to Gregory Szorc [:gps] from comment #4)
> Also, --enable-style=build only builds stylo, it doesn't enable it. I doubt
> that will achieve much more additional test coverage unless stylo is being
> enabled at run time. But if you enable stylo by default, you'll lose some
> coverage for non-stylo, which is the current build default. So the correct
> solution is to fuzz with style enabled and disabled until we drop the
> non-stylo system.

Yes. Jesse is trying to fuzz Stylo before we enable it by default, but the fuzzing builds didn't have Stylo support built in yet.
Assignee: nobody → cpeterson
Priority: -- → P2
Pushed by cpeterson@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/50d28d418535
Build Stylo for linux64 ASAN builds. r=gps
Depends on: 1382544
https://hg.mozilla.org/mozilla-central/rev/50d28d418535
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.