Closed
Bug 1382134
Opened 7 years ago
Closed 7 years ago
Search result shows the wrong section titles
Categories
(Firefox :: Settings UI, enhancement, P1)
Firefox
Settings UI
Tracking
()
VERIFIED
FIXED
Firefox 56
Tracking | Status | |
---|---|---|
firefox56 | --- | verified |
People
(Reporter: timdream, Assigned: evanxd)
References
Details
(Whiteboard: [photon-preference])
Attachments
(2 files)
See screenshot. We'll need to update Preferences search logic to take the section titles into consideration. Two problems need fixing, as demonstrated in the screenshot: 1. The visible group needs to have its associated section title shown, in this case, the "Startup" group is under "General". Noted that many groups can be associated with the same title. 2. The section title should not show on its own, rather, the entire section should be shown. In this case, the "Browser Privacy" section title has shown on its own. I am inferring these "correct" behaviors based on my understanding of the new Preferences section structure. Feel free to confirm that with Tina from UX.
Updated•7 years ago
|
Assignee: nobody → evan
Flags: qe-verify+
Priority: -- → P1
Whiteboard: [photon-preference][triage] → [photon-preference]
Target Milestone: --- → Firefox 56
Assignee | ||
Updated•7 years ago
|
Status: NEW → ASSIGNED
Assignee | ||
Comment 1•7 years ago
|
||
After discussed with Tina, we would like to just hide the section title in the case, just aligns previous UX design before reorg v2 landed.
Flags: needinfo?(thsieh)
Comment 2•7 years ago
|
||
Thanks Evan, let's hide the 1st level header from the search results. :)
Flags: needinfo?(thsieh)
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8888160 -
Flags: review?(jaws)
Assignee | ||
Comment 4•7 years ago
|
||
Hi Jared, Could you help review the patch? Thank you.
Comment 5•7 years ago
|
||
mozreview-review |
Comment on attachment 8888160 [details] Bug 1382134 - Do not show section title in search result. https://reviewboard.mozilla.org/r/159074/#review165918 r=me with the following change ::: browser/components/preferences/in-content-new/findInPage.js:251 (Diff revision 1) > - if (rootPreferencesChildren[i].className != "header" && > + if (rootPreferencesChildren[i].className != "subcategory" && > rootPreferencesChildren[i].className != "no-results-message" && These should be using classList.contains() instead of className.
Attachment #8888160 -
Flags: review?(jaws) → review+
Assignee | ||
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8888160 [details] Bug 1382134 - Do not show section title in search result. https://reviewboard.mozilla.org/r/159074/#review166042 ::: browser/components/preferences/in-content-new/findInPage.js:251 (Diff revision 1) > - if (rootPreferencesChildren[i].className != "header" && > + if (rootPreferencesChildren[i].className != "subcategory" && > rootPreferencesChildren[i].className != "no-results-message" && Sure, let's do it.
Comment hidden (mozreview-request) |
Assignee | ||
Comment 8•7 years ago
|
||
Updated the patch to fix nits. Let's land the patch once the try[1] is good. [1]: https://treeherder.mozilla.org/#/jobs?repo=try&revision=8e8b661639f1
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Comment 12•7 years ago
|
||
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/c3f4230e9a23 Do not show section title in search result. r=jaws
Keywords: checkin-needed
Comment 13•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/c3f4230e9a23
Comment 14•7 years ago
|
||
Build ID: 20170726155629 User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0 Verified as fixed on Firefox Nightly 56.0a1 on Windows 10 x 64, Mac OS X 10.12 and Ubuntu 16.04 x64.
Status: RESOLVED → VERIFIED
Updated•7 years ago
|
You need to log in
before you can comment on or make changes to this bug.
Description
•