Closed
Bug 1382141
Opened 8 years ago
Closed 8 years ago
Remove generate_frame from wr_api_set_root_pipeline()
Categories
(Core :: Graphics: WebRender, enhancement)
Core
Graphics: WebRender
Tracking
()
RESOLVED
FIXED
mozilla56
| Tracking | Status | |
|---|---|---|
| firefox56 | --- | fixed |
People
(Reporter: sotaro, Assigned: sotaro)
References
Details
Attachments
(1 file)
|
916 bytes,
patch
|
nical
:
review+
|
Details | Diff | Splinter Review |
It is not clear why generate_frame is necessary in wr_api_set_root_pipeline(). WebRenderBridgeParent::CompositeToTarget() calls generate_frame when it is necessary.
|
Assignee | |
Comment 1•8 years ago
|
||
Assignee: nobody → sotaro.ikeda.g
|
|
Assignee | |
Comment 2•8 years ago
|
||
|
|
Assignee | |
Updated•8 years ago
|
Attachment #8887837 -
Flags: review?(nical.bugzilla)
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8887837 [details] [diff] [review]
patch - Remove generate_frame from wr_api_set_root_pipeline()
Review of attachment 8887837 [details] [diff] [review]:
-----------------------------------------------------------------
Makes sense.
Attachment #8887837 -
Flags: review?(nical.bugzilla) → review+
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d3a0d05602dd
Remove generate_frame from wr_api_set_root_pipeline() r=nical
|
||
Comment 5•8 years ago
|
||
| bugherder | ||
Status: NEW → RESOLVED
Closed: 8 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•