Closed Bug 1382141 Opened 5 years ago Closed 5 years ago

Remove generate_frame from wr_api_set_root_pipeline()

Categories

(Core :: Graphics: WebRender, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: sotaro, Assigned: sotaro)

References

Details

Attachments

(1 file)

It is not clear why generate_frame is necessary in wr_api_set_root_pipeline(). WebRenderBridgeParent::CompositeToTarget() calls generate_frame when it is necessary.
Assignee: nobody → sotaro.ikeda.g
Attachment #8887837 - Flags: review?(nical.bugzilla)
Comment on attachment 8887837 [details] [diff] [review]
patch - Remove generate_frame from wr_api_set_root_pipeline()

Review of attachment 8887837 [details] [diff] [review]:
-----------------------------------------------------------------

Makes sense.
Attachment #8887837 - Flags: review?(nical.bugzilla) → review+
Pushed by sikeda@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d3a0d05602dd
Remove generate_frame from wr_api_set_root_pipeline() r=nical
Blocks: 1382132
https://hg.mozilla.org/mozilla-central/rev/d3a0d05602dd
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.