Closed Bug 1382187 Opened 6 years ago Closed 6 years ago

Add a filter on the devtools notification bar close icon

Categories

(DevTools :: Shared Components, enhancement, P3)

Product:
DevTools
Component:
Shared Components
Type:
enhancement

Tracking

(firefox57 fixed)

Status:
RESOLVED FIXED
Milestone:
Firefox 57
Tracking Flags:
Tracking Status
firefox57 --- fixed

People

(Reporter: Towkir, Assigned: abhinav.koppula, Mentored)

References

Details

(Keywords: good-first-bug)

Attachments

(2 files)

notification-bar-close-icon-dark-theme.png
24.82 KB, image/png
Details
Bug 1382187 - Theme specific filter added to devtools notification bar 'close' icon.
59 bytes, text/x-review-board-request
Honza
: review+
Details 
[A follow up bug from bug 1304837 and bug 1382184]
The devtools notification bar close icon is almost invisible on dark theme. A filter should be added on this so that it can revert colors based on themes to be visible properly.
Would you like to work on this ?
Flags: needinfo?(hossainalikram)
Mentor: odvarko
status-firefox57: --- → fix-optional
Keywords: good-first-bug
Priority: -- → P3
Hi Ahmed,
I have sent a mozreview-request for the above issue.
Was this what you were looking for?
Hi Honza,
Have created a review-request for this.
Can you please review once?
Hi Abhinav, I was about to bounce the review request to honza but first I wanted to check if your steps are correct and test things, but I could not manage time.
BTW, whenever you are working on a good-first bug, there should be some mentor on that bug and the mentor is usually the reviewer. Thus, honza is the reviewer of this bug. And it may take a bit of time to review sometimes (Assuming a reviewer may be busy sometimes)

Cheers!
Flags: needinfo?(hossainalikram)
As you are making progress on it, I am assigning it to you.
Assignee: nobody → abhinav.koppula
Status: NEW → ASSIGNED
Comment on attachment 8909084 [details]
Bug 1382187 - Theme specific filter added to devtools notification bar 'close' icon.

https://reviewboard.mozilla.org/r/180684/#review186980

Thanks for the patch, tested on Win10 and OSX, works for me!

R+

It would be great to also fix the text of the notification bar.
It's currently gray in both light and dark thems and a bit hard to read.
I think it should be black in light theme and white in dark theme.

I believe we can just use: var(--theme-toolbar-color) for the text.
Can you please file a follow up.

Thanks!
Honza
Attachment #8909084 - Flags: review?(odvarko) → review+
Keywords: checkin-needed
(In reply to Jan Honza Odvarko [:Honza] from comment #8)
> It would be great to also fix the text of the notification bar.
> It's currently gray in both light and dark thems and a bit hard to read.
> I think it should be black in light theme and white in dark theme.
> 
> I believe we can just use: var(--theme-toolbar-color) for the text.
> Can you please file a follow up.
So, there is already bug filled for this, bug 1382184

Honza
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/905ddac6491c
Theme specific filter added to devtools notification bar 'close' icon. r=Honza
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/905ddac6491c
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox57: fix-optional → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 57
Product: Firefox → DevTools
You need to log in before you can comment on or make changes to this bug.