[jsdbg2] Debugger fails to recognize async functions

RESOLVED FIXED in Firefox 56

Status

()

Core
JavaScript Engine
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: jimb, Assigned: jimb)

Tracking

unspecified
mozilla56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

7 months ago
In some cases, the Debugger API doesn't recognize `async function` functions as scripted functions. For example, the `Debugger.Object.prototype.script` accessor returns `undefined` when applied to an async function.

I have tests, and I'm working on a patch.
(Assignee)

Comment 1

7 months ago
Created attachment 8890145 [details] [diff] [review]
Handle async functions properly in Debugger API.
Attachment #8890145 - Flags: review?(ttromey)

Comment 2

7 months ago
Comment on attachment 8890145 [details] [diff] [review]
Handle async functions properly in Debugger API.

Review of attachment 8890145 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks for doing this.  This looks good.
Attachment #8890145 - Flags: review?(ttromey) → review+
(Assignee)

Updated

7 months ago
Keywords: checkin-needed

Comment 3

7 months ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/9ab04bf5afc5
Handle async functions properly in Debugger API. r=tromey
Keywords: checkin-needed

Comment 4

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/9ab04bf5afc5
Status: NEW → RESOLVED
Last Resolved: 7 months ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.