1382290 - Change FxA avatar rendering from crisp to auto

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement)

Description

[Ryan Feeley [:rfeeley]]

Attachment: crisp-edges.png

The Firefox Accounts profile picture renders crisply, but should be on auto.

Make sure this doesn't affect border on hover/active states.

Comment 1

[Edouard Oger [:eoger]]

CSS property Ryan is talking about: https://developer.mozilla.org/en-US/docs/Web/CSS/image-rendering

Comment 2

[John Lin]

Hi,

I would like to take this as my first bug. Please mark the assignee to me. Thanks!

Comment 3

[Edouard Oger [:eoger]]

Hi,

We typically assign a bug to a contributor once a patch has been posted.

Comment 4

[John Lin]

Hi Edouard,

I get it. I'll try. Thank you.

Comment 5

[Luciano I]

Attachment: Bug 1382290 - Change Fxa avatar rendering from crisp-edges to auto.

Review commit: https://reviewboard.mozilla.org/r/160302/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/160302/

Comment 6

[Edouard Oger [:eoger]]

Comment on attachment 8889243 [details]
Bug 1382290 - Change Fxa avatar rendering from crisp-edges to auto.

https://reviewboard.mozilla.org/r/160302/#review165552

This looks great thanks!
I also verified the appMenu and it looks like the avatar rendering is done right.

::: commit-message-5928d:1
(Diff revision 1)
> +BUG 1382290 - Change Fxa avatar rendering from crisp-edges to auto

- BUG -> Bug
- Add r?eoger at the end

=> Bug 1382290 - Change Fxa avatar rendering from crisp-edges to auto. r?eoger

Comment 7

[Edouard Oger [:eoger]]

You need to change the actual commit message ;)

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/36d1a7817bc0
Change Fxa avatar rendering from crisp-edges to auto. r=eoger

Comment 9

[Edouard Oger [:eoger]]

I fixed the bug message and landed this for you. Thanks a lot for contributing!

Comment 10

[Luciano I]

Comment on attachment 8889243 [details]
Bug 1382290 - Change Fxa avatar rendering from crisp-edges to auto.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/160302/diff/1-2/

Comment 11

[Luciano I]

Sorry for the delay eoger and thanks for the fix!

Comment 12

[Edouard Oger [:eoger]]

Comment on attachment 8889243 [details]
Bug 1382290 - Change Fxa avatar rendering from crisp-edges to auto.

https://reviewboard.mozilla.org/r/160302/#review165920

Comment 13

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/36d1a7817bc0