Closed Bug 1382290 Opened 6 years ago Closed 6 years ago

Change FxA avatar rendering from crisp to auto

Categories

(Firefox :: Sync, enhancement)

Product:
Firefox
Component:
Sync
Version:
49 Branch
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Firefox 56
Tracking Flags:
Tracking Status
firefox56 --- fixed

People

(Reporter: rfeeley, Assigned: lyret, Mentored)

Details

(Keywords: good-first-bug)

Attachments

(2 files)

crisp-edges.png
53.27 KB, image/png
Details
Bug 1382290 - Change Fxa avatar rendering from crisp-edges to auto.
59 bytes, text/x-review-board-request
eoger
: review+
Details
Attached image crisp-edges.png — 
The Firefox Accounts profile picture renders crisply, but should be on auto.

Make sure this doesn't affect border on hover/active states.
CSS property Ryan is talking about: https://developer.mozilla.org/en-US/docs/Web/CSS/image-rendering
Mentor: eoger
Keywords: good-first-bug
Hi,

I would like to take this as my first bug. Please mark the assignee to me. Thanks!
Hi,

We typically assign a bug to a contributor once a patch has been posted.
Hi Edouard,

I get it. I'll try. Thank you.
Attachment #8889243 - Flags: feedback?(eoger)
Comment on attachment 8889243 [details]
Bug 1382290 - Change Fxa avatar rendering from crisp-edges to auto.

https://reviewboard.mozilla.org/r/160302/#review165552

This looks great thanks!
I also verified the appMenu and it looks like the avatar rendering is done right.

::: commit-message-5928d:1
(Diff revision 1)
> +BUG 1382290 - Change Fxa avatar rendering from crisp-edges to auto

- BUG -> Bug
- Add r?eoger at the end

=> Bug 1382290 - Change Fxa avatar rendering from crisp-edges to auto. r?eoger
Attachment #8889243 - Flags: feedback?(eoger) → feedback+
Attachment #8889243 - Attachment description: BUG 1382290 - Change Fxa avatar rendering from crisp-edges to auto → Bug 1382290 - Change Fxa avatar rendering from crisp-edges to auto. r?eoger
You need to change the actual commit message ;)
Pushed by eoger@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/36d1a7817bc0
Change Fxa avatar rendering from crisp-edges to auto. r=eoger
I fixed the bug message and landed this for you. Thanks a lot for contributing!
Sorry for the delay eoger and thanks for the fix!
Comment on attachment 8889243 [details]
Bug 1382290 - Change Fxa avatar rendering from crisp-edges to auto.

https://reviewboard.mozilla.org/r/160302/#review165920
Attachment #8889243 - Flags: review?(eoger) → review+
Assignee: nobody → lyretandrpg
https://hg.mozilla.org/mozilla-central/rev/36d1a7817bc0
Status: NEW → RESOLVED
Closed: 6 years ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
You need to log in before you can comment on or make changes to this bug.