Closed Bug 1382314 Opened 3 years ago Closed 3 years ago

Invalidation is broken on https://www.highcharts.com/demo/3d-column-interactive with layer-free

Categories

(Core :: Graphics: WebRender, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: jrmuizel, Assigned: ethlin)

References

Details

(Whiteboard: [gfx-noted])

Attachments

(1 file)

Hovering over the columns should highlight them, but doesn't with layer-free.
Blocks: layers-free
Whiteboard: [gfx-noted]
Assignee: nobody → ethlin
I feel that using webrender in this page is slower than the original gecko. I will check the performance issue when I start to study svg performance.
Comment on attachment 8888206 [details]
Bug 1382314 - Fix invalidation problem for layers-free mode.

https://reviewboard.mozilla.org/r/159154/#review164758
Attachment #8888206 - Flags: review?(jmuizelaar) → review+
Pushed by ethlin@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/ba3c77118fd3
Fix invalidation problem for layers-free mode. r=jrmuizel
https://hg.mozilla.org/mozilla-central/rev/ba3c77118fd3
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
My patch causes every items keep repainting. That's because we didn't call 'ClearInvalidationStateBits'[1] after EndTransaction. The patches in Bug 1384000 will fix the problem.

[1] https://dxr.mozilla.org/mozilla-central/source/layout/painting/nsDisplayList.cpp#2279
You need to log in before you can comment on or make changes to this bug.