1382320 - Xpcshell IMAP test failure 2017-07-19

Status: RESOLVED FIXED

(Thunderbird :: General, defect)

Description

[Jorg K (CEST = GMT+2)]

TEST-UNEXPECTED-FAIL | mailnews/base/test/unit/test_imapPump.js | xpcshell return code: 0 [log…]
TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_imapMove.js | xpcshell return code: 0 [log…]
TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_filterNeedsBody.js | xpcshell return code: 0 [log…]
TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_downloadOffline.js | xpcshell return code: 0 [log…]
TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_offlineCopy.js | xpcshell return code: 0 [log…]
TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_cacheParts.js | xpcshell return code: 0 [log…]
TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_downloadOffline.js | xpcshell return code: 0 [log…]
TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_filterNeedsBody.js | xpcshell return code: 0 [log…]
TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_imapMove.js | xpcshell return code: 0 [log…]
TEST-UNEXPECTED-FAIL | mailnews/imap/test/unit/test_offlineCopy.js | xpcshell return code: 0 [log…]

20 Errors:
"CONSOLE_MESSAGE: (warn) [JavaScript Warning: "TypeError: can't assign to properties of (new Number(2)): not an object" {file: "C:\\slave\\test\\build\\tests\\xpcshell\\head.js" line: 1383}]"

M-C: last good: 1b065ffd8a535a0ad4c39a912af18e948e
M-C: first bad: a1ea69a3a0a760036e047f6ff89897aa7f

https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=1b065ffd8a535a0ad4c39a912af18e948e&tochange=a1ea69a3a0a760036e047f6ff89897aa7f

I can't see where this failure is coming from, I'll have to try on a local build.

Aria, can you spot the problem, seem like something JS-related.

Comment 1

[Jorg K (CEST = GMT+2)]

Or maybe a removed preference? From a debug log:
INFO -  PID 7696 | [7696] WARNING: NS_ENSURE_TRUE(aObserver) failed: file c:/builds/moz2_slave/tb-c-cen-w32-d-000000000000000/build/mozilla/modules/libpref/nsPrefBranch.cpp, line 748
INFO -  PID 7696 | [7696] WARNING: NS_ENSURE_SUCCESS(rv, rv) failed with result 0x80070057: file c:/builds/moz2_slave/tb-c-cen-w32-d-000000000000000/build/mozilla/modules/libpref/Preferences.cpp, line 1924

0x80070057 = NS_ERROR_ILLEGAL_VALUE

Comment 2

[Jorg K (CEST = GMT+2)]

Looks like this is related to bug 1380470.

All the tests that fail use |tests.forEach(add_task);|
https://dxr.mozilla.org/comm-central/search?q=tests.forEach(add_task)%3B&redirect=false

testing/xpcshell/head.jshead.js#544 which appears in the error log
c:\mozilla-source\comm-central\mozilla\testing\xpcshell\head.js:_do_main:223
c:\mozilla-source\comm-central\mozilla\testing\xpcshell\head.js:_execute_test:544
is run_test();

Mike, Andrew, do you have any indication why our tests fail now?

Comment 3

[Jorg K (CEST = GMT+2)]

Hmm, looks like our scheme

var tests = [
  setup,
  ...
];

function* setup() {
  // No offline download, otherwise nothing is cached.
  Services.prefs.setBoolPref("mail.server.server1.offline_download", false);
  ...
}

function run_test() {
  tests.forEach(add_task);
  run_next_test();
}

doesn't work any more.

Comment 4

[Tooru Fujisawa [:arai]]

> function add_test(properties, func = properties, isTask = false) {

now the add_test function expects the 2nd and 3rd parameters to be meaningful value.
so we shouldn't use forEach directly, that passes index as 2nd parameter, and array as 3rd parameter.

|tests.forEach(x => add_task(x))| would work.

Comment 5

[Tooru Fujisawa [:arai]]

oops, the explanation about 3rd parameter was wrong.

> function add_task(properties, func = properties) {
>   return add_test(properties, func, true);
> }

the issue is only about 2nd parameter.

Comment 6

[Jorg K (CEST = GMT+2)]

OK, thanks, I'll try that.

Comment 7

[Jorg K (CEST = GMT+2)]

Attachment: 1382320-add-task.patch

This works, thanks, Arai!

Comment 8

[Jorg K (CEST = GMT+2)]

https://hg.mozilla.org/comm-central/rev/2501146ba1d4b835df72dff6c15efe6a7d18dcdb