SpiderMonkey HashTable has poor hashing behavior for adjacent pointers

RESOLVED FIXED in Firefox 56

Status

()

RESOLVED FIXED
a year ago
a year ago

People

(Reporter: Ehsan, Assigned: Ehsan)

Tracking

unspecified
mozilla56
Points:
---

Firefox Tracking Flags

(firefox56 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Comment 1

a year ago
Created attachment 8888013 [details] [diff] [review]
Improve SpiderMonkey's pointer hashing function for pointers to neighboring memory locations

This is very similar to the fix to bug 1379282 for the XPCOM hashtables.
Attachment #8888013 - Flags: review?(jdemooij)
Comment on attachment 8888013 [details] [diff] [review]
Improve SpiderMonkey's pointer hashing function for pointers to neighboring memory locations

Review of attachment 8888013 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, this is actually simpler than before. We should keep an eye on AWFY after this lands.
Attachment #8888013 - Flags: review?(jdemooij) → review+

Comment 3

a year ago
Pushed by eakhgari@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/c0e5f705407b
Improve SpiderMonkey's pointer hashing function for pointers to neighboring memory locations; r=jandem
https://hg.mozilla.org/mozilla-central/rev/c0e5f705407b
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.