Remote or cache native look and feel metrics queries in content processes

NEW
Unassigned

Status

()

Core
Widget: Win32
P3
normal
9 months ago
7 months ago

People

(Reporter: Alex_Gaynor, Unassigned)

Tracking

(Blocks: 1 bug)

Trunk
Unspecified
Windows
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: sb+)

(Reporter)

Description

9 months ago
Doing this goes through a win32k syscall. Here's what a stacktrace looks like:


2 - USER32!NtUserGetCaretBlinkTime
    USER32!NtUserGetCaretBlinkTime
    xul!nsLookAndFeel::GetIntImpl+0xb5
    xul!mozilla::LookAndFeel::GetInt+0xc
    xul!nsCaret::ResetBlinking+0x40
    xul!nsCaret::SetVisible+0x14
    xul!mozilla::PresShell::SetCaretEnabled+0x1f
    xul!nsTextInputSelectionImpl::SetCaretEnabled+0x8c
    xul!mozilla::EditorBase::InitializeSelection+0x14a
    xul!mozilla::EditorBase::OnFocus+0xe
    xul!mozilla::EditorEventListener::Focus+0x25a
    xul!mozilla::EditorEventListener::HandleEvent+0x95

Updated

9 months ago
Group: core-security
Component: Security: Process Sandboxing → Widget: Win32
Whiteboard: sb+

Comment 1

9 months ago
accidentally marked this sec, please remove.
Flags: needinfo?(dveditz)
Group: core-security
Flags: needinfo?(dveditz)

Updated

9 months ago
Depends on: 1383659
(Reporter)

Comment 2

7 months ago
Another stack that passes through nsLookAndFeel:

    win32u!NtUserSystemParametersInfo
    USER32!RealSystemParametersInfoW+0x82
    UxTheme!ClassicSystemParametersInfoW+0x29
    UxTheme!_InternalSystemParametersInfo+0x29
    UxTheme!ThemeSystemParametersInfoW+0xcb
    USER32!SystemParametersInfoW+0xa7
    UxTheme!IsHighContrastMode+0x2a
    UxTheme!IsThemeActive+0x5a
    UxTheme!IsAppThemed+0x16
    xul!nsLookAndFeel::GetIntImpl+0x40d
    xul!nsCSSRuleProcessor::InitSystemMetrics+0x2db
    xul!nsCSSRuleProcessor::HasSystemMetric+0xe
    xul!GetSystemMetric+0x52

Updated

7 months ago
Priority: -- → P3

Updated

7 months ago
Summary: Stop trying to get the caret blink time in the content process → Remote or cache native look and feel metrics queries in content processes
You need to log in before you can comment on or make changes to this bug.