Closed Bug 1382331 Opened 3 years ago Closed 3 years ago

Redesign histograms in about:telemetry

Categories

(Toolkit :: Telemetry, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: flyingrub, Assigned: flyingrub)

References

Details

Attachments

(1 file)

No description provided.
Comment on attachment 8888024 [details]
Bug 1382331 - Redesign histograms in about:telemetry

https://reviewboard.mozilla.org/r/158892/#review164322

::: commit-message-1b065:2
(Diff revision 1)
> +Bug 1382331 - Redesign histograms in about:telemetry r?chutten
> +

Need some explanantion about "how" you redesigned them, maybe a bit on "why" as well.

::: toolkit/content/aboutTelemetry.js:1354
(Diff revision 1)
>        bar.style.height = belowEm + "em";
>        barDiv.appendChild(bar);
>  
>        // Add bucket label
> +      if (label.length > 3) {
> +        if (previousLongLabel) {

I don't understand this... you want to mark only some long labels as long?

To what end? There's no style that I see in this patch for .long-label
Attachment #8888024 - Flags: review?(chutten) → review-
Comment on attachment 8888024 [details]
Bug 1382331 - Redesign histograms in about:telemetry

https://reviewboard.mozilla.org/r/158892/#review165294
Attachment #8888024 - Flags: review?(chutten)
Comment on attachment 8888024 [details]
Bug 1382331 - Redesign histograms in about:telemetry

https://reviewboard.mozilla.org/r/158892/#review165788

LGTM
Attachment #8888024 - Flags: review?(chutten) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/bd140659a6b7
Redesign histograms in about:telemetry r=chutten
Keywords: checkin-needed
Flags: needinfo?(flyinggrub)
Keywords: checkin-needed
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/0f63a6b51c1b
Redesign histograms in about:telemetry r=chutten
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/0f63a6b51c1b
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in before you can comment on or make changes to this bug.