Closed
Bug 1382363
Opened 7 years ago
Closed 7 years ago
Revert `PlacesSyncUtils.bookmarks.pullChanges` to use a serial connection
Categories
(Firefox :: Sync, enhancement, P2)
Firefox
Sync
Tracking
()
RESOLVED
FIXED
Firefox 56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: lina, Assigned: lina)
References
Details
Attachments
(1 file)
`PlacesSyncUtils.bookmarks.pullChanges` is read-only, so it can theoretically use a concurrent connection (`promiseDBConnection`) instead of a serial one (`withConnectionWrapper`). However, that can return stale information, and it might not trigger an immediate follow-up sync if the tracker receives the observer notification before the transaction commits.
Assignee | ||
Comment 1•7 years ago
|
||
https://bugzilla.mozilla.org/show_bug.cgi?id=1382444#c9 also has a good explanation of what happens when we mix read-write and read-only connections.
Updated•7 years ago
|
Priority: -- → P2
Comment hidden (mozreview-request) |
Comment 3•7 years ago
|
||
mozreview-review |
Comment on attachment 8890066 [details] Bug 1382363 - Change most uses of `promiseDBConnection` to `withConnectionWrapper` in `PlacesSyncUtils`. https://reviewboard.mozilla.org/r/161126/#review166586 awesome!
Attachment #8890066 -
Flags: review?(markh) → review+
Pushed by kcambridge@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/43a99fa7cf02 Change most uses of `promiseDBConnection` to `withConnectionWrapper` in `PlacesSyncUtils`. r=markh
Comment 5•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/43a99fa7cf02
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Updated•6 years ago
|
Assignee: nobody → lina
You need to log in
before you can comment on or make changes to this bug.
Description
•