1382363 - Revert `PlacesSyncUtils.bookmarks.pullChanges` to use a serial connection

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement, P2)

Description

[Lina Butler [:lina]]

`PlacesSyncUtils.bookmarks.pullChanges` is read-only, so it can theoretically use a concurrent connection (`promiseDBConnection`) instead of a serial one (`withConnectionWrapper`).

However, that can return stale information, and it might not trigger an immediate follow-up sync if the tracker receives the observer notification before the transaction commits.

Comment 1

[Lina Butler [:lina]]

https://bugzilla.mozilla.org/show_bug.cgi?id=1382444#c9 also has a good explanation of what happens when we mix read-write and read-only connections.

Comment 2

[Lina Butler [:lina]]

Attachment: Bug 1382363 - Change most uses of `promiseDBConnection` to `withConnectionWrapper` in `PlacesSyncUtils`.

The read-only `promiseDBConnection` can return stale data if writes
are still pending. This patch changes `PlacesSyncUtils` to use the
read-write `withConnectionWrapper` instead, ensuring we fetch
up-to-date info.

I didn't change `fetchURLFrecency` and `fetchGuidsWithAnno`.
`fetchURLFrecency` is only used to set the sort index for history
records, and frecency is recalculated in the background, anyway.
`fetchGuidsWithAnno` is only used in tests.

Review commit: https://reviewboard.mozilla.org/r/161126/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/161126/

Comment 3

[Mark Hammond [:markh] [:mhammond]]

Comment on attachment 8890066 [details]
Bug 1382363 - Change most uses of `promiseDBConnection` to `withConnectionWrapper` in `PlacesSyncUtils`.

https://reviewboard.mozilla.org/r/161126/#review166586

awesome!

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43a99fa7cf02
Change most uses of `promiseDBConnection` to `withConnectionWrapper` in `PlacesSyncUtils`. r=markh

Comment 5

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/43a99fa7cf02