Closed Bug 1382373 Opened 7 years ago Closed 7 years ago

flash of white when opening new tab page

Categories

(Firefox :: New Tab Page, defect)

defect
Not set
normal

Tracking

()

RESOLVED DUPLICATE of bug 1379587
Tracking Status
firefox57 --- affected

People

(Reporter: asa, Unassigned)

References

Details

Attachments

(1 file)

In the latest nightly I get a flash of white before the search and tiles are displayed when opening a new tab. I don't recall seeing this flash with the old new tab page. 

Steps to reproduce:

1. Have a new tab open
2. Open another new tab

Results: see a flash of white while the new tab loads up before the search and tiles are displayed.

Expected results: no flash of white. The new tab should load with its content already visible.

Tested with latest nightly on Win10
Nightly went from original new tab to compact tiles new tab and back to the original new tab. See bug 1379860. By latest you mean the original new tab? That shouldn't be a recent regression since nothing has changed on it. Could you confirm you which new tab you are talking about?
Flags: needinfo?(asa)
This is with the new New Tab page (Activity Stream).
Flags: needinfo?(asa)
OK. Activity Stream is not on Nightly by default.

ni Tim go get this moved to Activity Stream instead.
Flags: needinfo?(tspurway)
Component: New Tab Page → Activity Streams: Application Servers
Flags: needinfo?(tspurway)
Component: Activity Streams: Application Servers → Activity Streams: Newtab
Not sure if it matters, but even with with search, top sites, and Recommended by Pocket options turned off, the flash is still apparent. Tested the latest nightly on Ubuntu 16.04 (no problems with the old new tab page in Firefox 56.0b2).
billm: Could this be related to bug 1132072? Where about:newtab is now in content process and isn't immediately switched to upon new tab (maybe)?

It looks like the xul:tabpanels is being shown, and can be tested with:

gBrowser.mPanelContainer.style.backgroundColor = "green";

I suppose one hack is to just make that background color the same as what would be on about:newtab…
Flags: needinfo?(wmccloskey)
Actually, the white is coming from browser.display.background_color pref default of #ffffff:

https://searchfox.org/mozilla-central/source/browser/base/content/tabbrowser.xml#5496-5499

dao, any suggestions on how to approach this?

Do we just set that pref's value to Photon's Grey 10? (Activity Stream will be updating its background to Grey 10 soon. See https://github.com/mozilla/activity-stream/issues/2979#issuecomment-320752977 )
Flags: needinfo?(dao+bmo)
This only happens when quickly opening a second new tab before it could be preloaded, right? That sounds like a rather constructed test case, not something we should optimize for. The default background color is relevant not only to the new tab page but also to web pages that aren't going to use the photon color palette...
Flags: needinfo?(dao+bmo)
This happens every single time a new tab is opened, not just when several are opened in quick succession (if that was the implication?).
This sounds like it might be our optimization for showing "white" when switching to a tab that's in the process of loading. I can't remember the bug number for that.
Flags: needinfo?(wmccloskey) → needinfo?(mconley)
(In reply to Aibara Iduas from comment #8)
> This happens every single time a new tab is opened, not just when several
> are opened in quick succession (if that was the implication?).

This shouldn't happen since this page is preloaded.

That delay seems to be the real problem here, not the default browser background which I don't think we'll change.
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: needinfo?(mconley)
Resolution: --- → DUPLICATE
Component: Activity Streams: Newtab → New Tab Page
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: