138242 - Venkman should have the window menu

Status: VERIFIED FIXED

(Other Applications Graveyard :: Venkman JS Debugger, enhancement)

Description

[Olli Pettay [:smaug][[e-mail]]]

Summary says enough...

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

The fix is trivial. Just add the following to
venkman-menus.xul line 128.

        <!-- Window menu-->
        <menu id="windowMenu"/>

Comment 2

[Boris Zbarsky [:bzbarsky]]

confirmed

Comment 3

[Olli Pettay [:smaug][[e-mail]]]

Attachment: The patch

Reviews?

Comment 4

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 80195 [details] [diff] [review]
The patch

r=caillon.  This doesn't need sr= though, just rginda to r= it.  (Or is my r=
enough for this small patch?)

Comment 5

[Olli Pettay [:smaug][[e-mail]]]

Well, if r=caillon is enough could someone check it in?

Comment 6

[Christopher Aillon (sabbatical, not receiving bugmail)]

You need r=rginda.  He hasn't given me authority to have my r= be enough.  I can
check this in for you (or he can) when he reviews it.

Comment 7

[Robert Ginda]

Comment on attachment 80195 [details] [diff] [review]
The patch

r=rginda, caillon, feel free to check this in

Comment 8

[Olli Pettay [:smaug][[e-mail]]]

caillon could you check this in. Thanks.

Comment 9

[[e-mail]]

Bah. Dup of 136130 if you ask me :-)

Comment 10

[Robert Ginda]

fixed

Comment 11

[Christopher Aillon (sabbatical, not receiving bugmail)]

Verify fixed.  (I thought I marked it fixed already.  Oops)