Closed Bug 1382438 Opened 7 years ago Closed 7 years ago

Intermittent dom/vr/test/mochitest/test_vrController_displayId.html | Test timed out. - Test timed out.

Categories

(Core :: WebVR, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla56
Tracking Status
firefox56 --- fixed

People

(Reporter: intermittent-bug-filer, Assigned: daoshengmu)

References

Details

(Keywords: intermittent-failure, Whiteboard: [stockwell fixed:product])

Attachments

(2 files, 1 obsolete file)

This is fallout from bug 1375816 and sort of frequent. Please investigate and fix the issue.
Blocks: 1375816
Flags: needinfo?(dmu)
thanks for working on this :aryx.  

we have 35 failures since this started 2 days ago, this is a high priority to resolve:
https://brasstacks.mozilla.com/orangefactor/index.html?display=Bug&bugid=1382438&startday=2017-07-14&endday=2017-07-21&tree=trunk

:daoshengmu can you get this resolved in the next business day or two?
Whiteboard: [stockwell needswork]
Attached patch replaceWithSimpleTest(wip).diff (obsolete) — Splinter Review
I am considering replace it with SimpleTest. Hope it would be easier to avoid the intermittent.
Flags: needinfo?(dmu)
I just saw some bugs in GamepadManager and gfxVRPuppet that perhaps make this intermittent. I have fixed them locally and wait for the try results. Hopefully, it would not affect our real use cases.
Assignee: nobody → dmu
Comment on attachment 8890733 [details]
Bug 1382438 - Part 1: Get gamepads from globalWindow correctly for button and axis events;

https://reviewboard.mozilla.org/r/161928/#review167220

LGTM, thanks.
Attachment #8890733 - Flags: review?(cleu) → review+
Comment on attachment 8890734 [details]
Bug 1382438 - Part 2: Replace vr controller displayId test with gamepadbuttondown event;

https://reviewboard.mozilla.org/r/161930/#review167520

LGTM, Thanks!
Attachment #8890734 - Flags: review?(kgilbert) → review+
Attachment #8890159 - Attachment is obsolete: true
Pushed by dmu@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f29dc4908f51
Part 1: Get gamepads from globalWindow correctly for button and axis events; r=Lenzak
https://hg.mozilla.org/integration/autoland/rev/425118d805ee
Part 2: Replace vr controller displayId test with gamepadbuttondown event; r=kip
https://hg.mozilla.org/mozilla-central/rev/f29dc4908f51
https://hg.mozilla.org/mozilla-central/rev/425118d805ee
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
Whiteboard: [stockwell needswork] → [stockwell fixed:product]
https://hg.mozilla.org/projects/jamun/rev/f29dc4908f511f15c2664417f6b96b571c39f8f8
Bug 1382438 - Part 1: Get gamepads from globalWindow correctly for button and axis events; r=Lenzak

https://hg.mozilla.org/projects/jamun/rev/425118d805ee9b3b71c942ad29a32b15c769fbea
Bug 1382438 - Part 2: Replace vr controller displayId test with gamepadbuttondown event; r=kip
You need to log in before you can comment on or make changes to this bug.