Closed Bug 138245 Opened 21 years ago Closed 13 years ago

Drag and dropping a url with an extra space on to the tab bar fails


(SeaMonkey :: Tabbed Browser, defect)

Not set


(Not tracked)



(Reporter: zevious, Unassigned)




(1 file)

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:0.9.9+)
BuildID:    2002041803

If you highligh a url on a page and then drag and drop it to the tabbar, the url
is loaded in a new tab. This fails if you have an extra space on the end of the
url. Unfortunately, when cutting and pasting, this happens REAL easy.

Reproducible: Always
Steps to Reproduce:
1. Open Mozilla
2. Highlight a url on a webpage but "accidently" include an extra space on the end.
3. Drag and drop it on the tabbar.
4. Withness the failure.
5. Try it without the space and it works.

Actual Results:  Failure

Expected Results:  Tab opens with correct page.
qa -->
QA Contact: paw → tpreston
Ever confirmed: true
-> Tabbed Browser
Component: XP Apps → Tabbed Browser
Reassigning to default owner.
Assignee: sgehani → jaggernaut
QA Contact: tpreston → sairuh
QA Contact: sairuh → pmac
*** Bug 184011 has been marked as a duplicate of this bug. ***
The real problem with this bug is for the unlinked url's of course.  When I
double click some of those url's they get highlighted perfectly except for
adding a space on the end.  So this isn't just a problem of user error while
dragging over the url with the mouse.  What is normally a very slick feature is
rendered totally awkward.
*** Bug 276819 has been marked as a duplicate of this bug. ***
*** Bug 306622 has been marked as a duplicate of this bug. ***
To clarify: this happens when dragging into an existing tab, when dragging to an empty space on the tabbar (to open a new tab), and when dragging into the content area of another browser window.
OS: Windows XP → All
Hardware: PC → All
*** Bug 260761 has been marked as a duplicate of this bug. ***
Attached patch patchSplinter Review
Patch for both Firefox and SeaMonkey (xpfe), and for both the tabbar and the content area cases. This could be split into separate patches if required.
Assignee: jag → uriber
Attachment #200858 - Flags: review?(bugs.mano)
Comment on attachment 200858 [details] [diff] [review]

See comments in bug 252441, the whitespcae check seems to be very wrong.
Attachment #200858 - Flags: review?(bugs.mano) → review-
Depends on: 252441
Assignee: uriber → nobody
QA Contact: pmac → tabbed-browser
*** Bug 350161 has been marked as a duplicate of this bug. ***
I think that the trailing and heading spaces are not a part of the URI if the URI is nsStandardURL. Should we clean-up the spaces in nsStandardURL? So I think that (1) we create the URI object form URI string, (2) the URI objects clean-up the URI at creating and (3) we get and use the clean-upped URI string. How about this?
Product: Core → SeaMonkey
WFM: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b9pre) Gecko/20110101 SeaMonkey/2.1b2pre
Closed: 13 years ago
Resolution: --- → WORKSFORME
You need to log in before you can comment on or make changes to this bug.