Closed
Bug 138245
Opened 23 years ago
Closed 14 years ago
Drag and dropping a url with an extra space on to the tab bar fails
Categories
(SeaMonkey :: Tabbed Browser, defect)
SeaMonkey
Tabbed Browser
Tracking
(Not tracked)
RESOLVED
WORKSFORME
People
(Reporter: zevious, Unassigned)
References
Details
Attachments
(1 file)
4.80 KB,
patch
|
asaf
:
review-
|
Details | Diff | Splinter Review |
From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:0.9.9+)
Gecko/20020418
BuildID: 2002041803
If you highligh a url on a page and then drag and drop it to the tabbar, the url
is loaded in a new tab. This fails if you have an extra space on the end of the
url. Unfortunately, when cutting and pasting, this happens REAL easy.
Reproducible: Always
Steps to Reproduce:
1. Open Mozilla
2. Highlight a url on a webpage but "accidently" include an extra space on the end.
3. Drag and drop it on the tabbar.
4. Withness the failure.
5. Try it without the space and it works.
Actual Results: Failure
Expected Results: Tab opens with correct page.
Updated•23 years ago
|
Status: UNCONFIRMED → NEW
Ever confirmed: true
Comment 3•23 years ago
|
||
Reassigning to default owner.
Assignee: sgehani → jaggernaut
QA Contact: tpreston → sairuh
Updated•22 years ago
|
QA Contact: sairuh → pmac
*** Bug 184011 has been marked as a duplicate of this bug. ***
The real problem with this bug is for the unlinked url's of course. When I
double click some of those url's they get highlighted perfectly except for
adding a space on the end. So this isn't just a problem of user error while
dragging over the url with the mouse. What is normally a very slick feature is
rendered totally awkward.
Comment 6•19 years ago
|
||
*** Bug 276819 has been marked as a duplicate of this bug. ***
Comment 7•19 years ago
|
||
*** Bug 306622 has been marked as a duplicate of this bug. ***
Comment 8•19 years ago
|
||
To clarify: this happens when dragging into an existing tab, when dragging to an empty space on the tabbar (to open a new tab), and when dragging into the content area of another browser window.
Updated•19 years ago
|
OS: Windows XP → All
Hardware: PC → All
Comment 9•19 years ago
|
||
*** Bug 260761 has been marked as a duplicate of this bug. ***
Comment 10•19 years ago
|
||
Comment 11•19 years ago
|
||
Patch for both Firefox and SeaMonkey (xpfe), and for both the tabbar and the content area cases. This could be split into separate patches if required.
Comment 12•19 years ago
|
||
Comment on attachment 200858 [details] [diff] [review]
patch
See comments in bug 252441, the whitespcae check seems to be very wrong.
Attachment #200858 -
Flags: review?(bugs.mano) → review-
Updated•19 years ago
|
Assignee: uriber → nobody
Status: ASSIGNED → NEW
QA Contact: pmac → tabbed-browser
Comment 13•18 years ago
|
||
*** Bug 350161 has been marked as a duplicate of this bug. ***
Comment 14•18 years ago
|
||
I think that the trailing and heading spaces are not a part of the URI if the URI is nsStandardURL. Should we clean-up the spaces in nsStandardURL? So I think that (1) we create the URI object form URI string, (2) the URI objects clean-up the URI at creating and (3) we get and use the clean-upped URI string. How about this?
Assignee | ||
Updated•16 years ago
|
Product: Core → SeaMonkey
Comment 15•14 years ago
|
||
WFM: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b9pre) Gecko/20110101 SeaMonkey/2.1b2pre
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → WORKSFORME
You need to log in
before you can comment on or make changes to this bug.
Description
•