138245 - Drag and dropping a url with an extra space on to the tab bar fails

Status: RESOLVED WORKSFORME

(SeaMonkey :: Tabbed Browser, defect)

Description

[Carl Schrader]

From Bugzilla Helper:
User-Agent: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:0.9.9+)
Gecko/20020418
BuildID:    2002041803

If you highligh a url on a page and then drag and drop it to the tabbar, the url
is loaded in a new tab. This fails if you have an extra space on the end of the
url. Unfortunately, when cutting and pasting, this happens REAL easy.

Reproducible: Always
Steps to Reproduce:
1. Open Mozilla
2. Highlight a url on a webpage but "accidently" include an extra space on the end.
3. Drag and drop it on the tabbar.
4. Withness the failure.
5. Try it without the space and it works.

Actual Results:  Failure

Expected Results:  Tab opens with correct page.

Comment 1

[Paul Wyskoczka]

qa --> [e-mail]

Comment 2

[Samir Gehani]

-> Tabbed Browser

Comment 3

[Samir Gehani]

Reassigning to default owner.

Comment 4

[u60234]

*** Bug 184011 has been marked as a duplicate of this bug. ***

Comment 5

[Jay Davis]

The real problem with this bug is for the unlinked url's of course.  When I
double click some of those url's they get highlighted perfectly except for
adding a space on the end.  So this isn't just a problem of user error while
dragging over the url with the mouse.  What is normally a very slick feature is
rendered totally awkward.

Comment 6

[Uri Bernstein]

*** Bug 276819 has been marked as a duplicate of this bug. ***

Comment 7

[Uri Bernstein]

*** Bug 306622 has been marked as a duplicate of this bug. ***

Comment 8

[Uri Bernstein]

To clarify: this happens when dragging into an existing tab, when dragging to an empty space on the tabbar (to open a new tab), and when dragging into the content area of another browser window.

Comment 9

[Uri Bernstein]

*** Bug 260761 has been marked as a duplicate of this bug. ***

Comment 10

[Uri Bernstein]

   http://www.google.com

Comment 11

[Uri Bernstein]

Attachment: patch

Patch for both Firefox and SeaMonkey (xpfe), and for both the tabbar and the content area cases. This could be split into separate patches if required.

Comment 12

[Asaf Romano (gone)]

Comment on attachment 200858 [details] [diff] [review]
patch

See comments in bug 252441, the whitespcae check seems to be very wrong.

Comment 13

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

*** Bug 350161 has been marked as a duplicate of this bug. ***

Comment 14

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

I think that the trailing and heading spaces are not a part of the URI if the URI is nsStandardURL. Should we clean-up the spaces in nsStandardURL? So I think that (1) we create the URI object form URI string, (2) the URI objects clean-up the URI at creating and (3) we get and use the clean-upped URI string. How about this?

Comment 15

[Philip Chee]

WFM: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:2.0b9pre) Gecko/20110101 SeaMonkey/2.1b2pre