Intermittent browser/components/urlbar/tests/browser/browser_raceWithTabs.js | New tab still has about:newtab - Got about:blank, expected about:newtab

RESOLVED FIXED in Firefox 67

Status

()

defect
P3
normal
RESOLVED FIXED
2 years ago
3 months ago

People

(Reporter: intermittent-bug-filer, Assigned: mak)

Tracking

({bulk-close-intermittents, intermittent-failure})

unspecified
Firefox 67
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox67 fixed)

Details

(Whiteboard: [fxsearch][test disabled on linux][stockwell unknown])

Attachments

(1 attachment)

Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → INCOMPLETE
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Assignee

Updated

2 years ago
Priority: -- → P5
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
Status: REOPENED → RESOLVED
Closed: 2 years agoLast year
Resolution: --- → INCOMPLETE
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
Status: REOPENED → RESOLVED
Closed: Last yearLast year
Resolution: --- → INCOMPLETE
Comment hidden (Intermittent Failures Robot)
Recent failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=189700166&repo=autoland&lineNumber=2931

20:43:13     INFO - TEST-START | browser/base/content/test/urlbar/browser_urlbarRaceWithTabs.js
20:43:14     INFO - TEST-INFO | started process screencapture
20:43:14     INFO - TEST-INFO | screencapture: exit 0
20:43:14     INFO - Buffered messages logged at 20:43:13
20:43:14     INFO - Entering test bound hitEnterLoadInRightTab
20:43:14     INFO - Opening new tab
20:43:14     INFO - Creating bookmark and keyword
20:43:14     INFO - Filling URL bar, sending <return> and opening a tab
20:43:14     INFO - Waiting for new tab
20:43:14     INFO - Buffered messages logged at 20:43:14
20:43:14     INFO - Created new tab; waiting for either tab to load
20:43:14     INFO - Old tab loaded
20:43:14     INFO - Buffered messages finished
20:43:14     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/urlbar/browser_urlbarRaceWithTabs.js | New tab still has about:newtab - Got about:blank, expected about:newtab
20:43:14     INFO - Stack trace:
20:43:14     INFO - chrome://mochikit/content/browser-test.js:test_is:1305
20:43:14     INFO - chrome://mochitests/content/browser/browser/base/content/test/urlbar/browser_urlbarRaceWithTabs.js:hitEnterLoadInRightTab:50
20:43:14     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1103
20:43:14     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1094
20:43:14     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:996
20:43:14     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
20:43:14     INFO - TEST-PASS | browser/base/content/test/urlbar/browser_urlbarRaceWithTabs.js | Old tab loaded URL - 
20:43:14     INFO - Closing new tab
20:43:14     INFO - Closing old tab
20:43:14     INFO - Finished
20:43:14     INFO - Leaving test bound hitEnterLoadInRightTab
20:43:14     INFO - GECKO(906) | MEMORY STAT | vsize 4643MB | residentFast 604MB | heapAllocated 178MB
20:43:14     INFO - TEST-OK | browser/base/content/test/urlbar/browser_urlbarRaceWithTabs.js | took 334ms
20:43:14     INFO - checking window state
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
https://wiki.mozilla.org/Bug_Triage#Intermittent_Test_Failure_Cleanup
Status: REOPENED → RESOLVED
Closed: Last year9 months ago
Resolution: --- → INCOMPLETE
Recent failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=202215511&repo=mozilla-inbound&lineNumber=2762

06:13:39     INFO - TEST-START | browser/base/content/test/urlbar/browser_urlbarRaceWithTabs.js
06:13:40     INFO - TEST-INFO | started process screencapture
06:13:40     INFO - TEST-INFO | screencapture: exit 0
06:13:40     INFO - Buffered messages logged at 06:13:39
06:13:40     INFO - Entering test bound hitEnterLoadInRightTab
06:13:40     INFO - Opening new tab
06:13:40     INFO - Buffered messages logged at 06:13:40
06:13:40     INFO - Creating bookmark and keyword
06:13:40     INFO - Filling URL bar, sending <return> and opening a tab
06:13:40     INFO - Waiting for new tab
06:13:40     INFO - Created new tab; waiting for either tab to load
06:13:40     INFO - Old tab loaded
06:13:40     INFO - Buffered messages finished
06:13:40     INFO - TEST-UNEXPECTED-FAIL | browser/base/content/test/urlbar/browser_urlbarRaceWithTabs.js | New tab still has about:newtab - Got about:blank, expected about:newtab
06:13:40     INFO - Stack trace:
06:13:40     INFO - chrome://mochikit/content/browser-test.js:test_is:1295
06:13:40     INFO - chrome://mochitests/content/browser/browser/base/content/test/urlbar/browser_urlbarRaceWithTabs.js:hitEnterLoadInRightTab:50
06:13:40     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest/<:1093
06:13:40     INFO - chrome://mochikit/content/browser-test.js:Tester_execTest:1084
06:13:40     INFO - chrome://mochikit/content/browser-test.js:nextTest/<:986
06:13:40     INFO - chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<:795
06:13:40     INFO - TEST-PASS | browser/base/content/test/urlbar/browser_urlbarRaceWithTabs.js | Old tab loaded URL - 
06:13:40     INFO - Closing new tab
06:13:40     INFO - Closing old tab
06:13:40     INFO - Finished
06:13:40     INFO - Leaving test bound hitEnterLoadInRightTab
06:13:40     INFO - Console message: [JavaScript Warning: "Loading failed for the <script> with source “resource://activity-stream/prerendered/static/activity-stream-initial-state.js”." {file: "about:newtab" line: 1}]
06:13:40     INFO - Console message: [JavaScript Warning: "Loading failed for the <script> with source “chrome://browser/content/contentSearchUI.js”." {file: "about:newtab" line: 1}]
06:13:40     INFO - Console message: [JavaScript Warning: "Loading failed for the <script> with source “chrome://browser/content/contentTheme.js”." {file: "about:newtab" line: 1}]
06:13:40     INFO - Console message: [JavaScript Warning: "Loading failed for the <script> with source “resource://activity-stream/vendor/react.js”." {file: "about:newtab" line: 1}]
06:13:40     INFO - Console message: [JavaScript Warning: "Loading failed for the <script> with source “resource://activity-stream/vendor/react-dom.js”." {file: "about:newtab" line: 1}]
06:13:40     INFO - Console message: [JavaScript Warning: "Loading failed for the <script> with source “resource://activity-stream/vendor/prop-types.js”." {file: "about:newtab" line: 1}]
06:13:40     INFO - Console message: [JavaScript Warning: "Loading failed for the <script> with source “resource://activity-stream/vendor/react-intl.js”." {file: "about:newtab" line: 1}]
06:13:40     INFO - Console message: [JavaScript Warning: "Loading failed for the <script> with source “resource://activity-stream/vendor/redux.js”." {file: "about:newtab" line: 1}]
06:13:40     INFO - Console message: [JavaScript Warning: "Loading failed for the <script> with source “resource://activity-stream/vendor/react-redux.js”." {file: "about:newtab" line: 1}]
06:13:40     INFO - Console message: [JavaScript Warning: "Loading failed for the <script> with source “resource://activity-stream/prerendered/en-US/activity-stream-strings.js”." {file: "about:newtab" line: 1}]
06:13:40     INFO - Console message: [JavaScript Warning: "Loading failed for the <script> with source “resource://activity-stream/data/content/activity-stream.bundle.js”." {file: "about:newtab" line: 1}]
06:13:40     INFO - GECKO(984) | MEMORY STAT | vsize 4587MB | residentFast 503MB | heapAllocated 170MB
06:13:40     INFO - TEST-OK | browser/base/content/test/urlbar/browser_urlbarRaceWithTabs.js | took 342ms
Status: RESOLVED → REOPENED
Resolution: INCOMPLETE → ---
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
There are 96 failures asociated to this bug in the last 7 days. These are occurring on Linux platforms !debug builds.

::mak can you take a look at this?
Flags: needinfo?(mak77)
Whiteboard: [stockwell needswork]
Comment hidden (Intermittent Failures Robot)
Assignee

Comment 40

8 months ago
It looks like something that landed last week has largely increased the likelihood of this failure :(
I'll see if I can figure out something.
Assignee: nobody → mak77
Status: REOPENED → ASSIGNED
Priority: P5 → P1
Whiteboard: [stockwell needswork] → [stockwell needswork][fxsearch]
Assignee

Comment 41

8 months ago
Standard8 pointed out that last week bug 1362774 landed, that may have slightly changed timings on new tabs. The timeframe of that landing seems compatible with the failure increase.

Comment 42

8 months ago
(In reply to Marco Bonardo [::mak] from comment #41)
> Standard8 pointed out that last week bug 1362774 landed, that may have
> slightly changed timings on new tabs. The timeframe of that landing seems
> compatible with the failure increase.

It's of course possible, though it would surprise me somewhat as bug 1362774 only affects the initial tab in a window. Off-hand, I don't see how it'd impact creation of new tabs, as the test here doesn't seem to create any new windows.

Do tests that run right before this one maybe create new windows?
Comment hidden (Intermittent Failures Robot)
Assignee

Comment 44

8 months ago
I disabled the test on Linux in bug 1504880, while we investigate it.
Flags: needinfo?(mak77)
Whiteboard: [stockwell needswork][fxsearch] → [stockwell needswork][fxsearch][test disabled on linux]
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Assignee

Comment 50

6 months ago
(In reply to :Gijs (he/him) from comment #42)
> Do tests that run right before this one maybe create new windows?

Oh yes, browser_urlbarPrivateBrowsingWindowChange.js runs just before this one and opens a window.
Assignee

Updated

6 months ago
Blocks: 1362774
Assignee

Comment 51

6 months ago
I tried to wait for focus when we close the window in the previous test, like we did elsewhere, but that's not enough to solve this failure. It will require more logging and debugging.
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)

The recent spike in failures are all test-verify, triggered by the test being moved in bug 1514164.

Most (all?) failures are in step 1 of test-verify, which is roughly equivalent to running the test with --repeat=10.

Comment hidden (Intermittent Failures Robot)
Assignee

Updated

5 months ago
Priority: P1 → P3
Assignee

Comment 58

4 months ago

Not actively working on this, would still be nice to find a solution, the good thing is that it's not that common out of linux.

Assignee: mak77 → nobody
Status: ASSIGNED → UNCONFIRMED
Ever confirmed: false
Comment hidden (Intermittent Failures Robot)
Summary: Intermittent browser/base/content/test/urlbar/browser_urlbarRaceWithTabs.js | New tab still has about:newtab - Got about:blank, expected about:newtab → Intermittent browser/components/urlbar/tests/legacy/browser_urlbarRaceWithTabs.js | New tab still has about:newtab - Got about:blank, expected about:newtab
Comment hidden (Intermittent Failures Robot)
Comment hidden (Intermittent Failures Robot)
Summary: Intermittent browser/components/urlbar/tests/legacy/browser_urlbarRaceWithTabs.js | New tab still has about:newtab - Got about:blank, expected about:newtab → Intermittent browser/components/urlbar/tests/browser/browser_raceWithTabs.js | New tab still has about:newtab - Got about:blank, expected about:newtab

This bug has failed 36 times in the last 7 days. Occurs on osx-10-10, windows10-64 and windows7-32 on pgo, debug and opt build types.

Recent log:
https://treeherder.mozilla.org/logviewer.html#?job_id=232218672&repo=mozilla-inbound

Mak: Since you are not working on this bug? Can you appoint somebody else to it?

Flags: needinfo?(mak77)
Whiteboard: [fxsearch][test disabled on linux][stockwell unknown] → [fxsearch][test disabled on linux][stockwell needswork]
Comment hidden (Intermittent Failures Robot)
Assignee

Comment 64

3 months ago

I think we can change the test to check the tab is not the given url, rather than about:blank/newTab, it's possible due to laziness that the tab didn't switch to newTab yet. I have an half made idea to try.

Assignee: nobody → mak77
Status: UNCONFIRMED → ASSIGNED
Ever confirmed: true
Flags: needinfo?(mak77)

Comment 66

3 months ago
Pushed by mak77@bonardo.net:
https://hg.mozilla.org/integration/autoland/rev/33c69b500eed
Intermittent failure in browser_raceWithTabs.js. r=Standard8

Comment 67

3 months ago
bugherder
Status: ASSIGNED → RESOLVED
Closed: 9 months ago3 months ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 67
Assignee

Updated

3 months ago
See Also: → 1533807
Comment hidden (Intermittent Failures Robot)
You need to log in before you can comment on or make changes to this bug.