Closed
Bug 1382487
Opened 7 years ago
Closed 7 years ago
Intermittent browser/components/extensions/test/browser/test-oop-extensions/browser_ext_devtools_panels_elements.js | Got the expected onSelectionChanged once the tab navigated - Got BODY, expected undefined
Categories
(WebExtensions :: Developer Tools, defect, P2)
WebExtensions
Developer Tools
Tracking
(firefox56 fixed, firefox57 fixed)
RESOLVED
FIXED
mozilla57
People
(Reporter: intermittent-bug-filer, Assigned: rpl)
Details
(Keywords: intermittent-failure, Whiteboard: [stockwell fixed:other])
Attachments
(1 file)
Filed by: wkocher [at] mozilla.com https://treeherder.mozilla.org/logviewer.html#?job_id=115628450&repo=mozilla-inbound https://queue.taskcluster.net/v1/task/S6nNpj3CRounTsCtbbaisQ/runs/0/artifacts/public/logs/live_backing.log
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Comment 3•7 years ago
|
||
:andym, this has a high failure rate last week and a higher failure rate this week (when looking at the graph for august). can you find someone to look into this as it appears to be a persistent failure.
Flags: needinfo?(amckay)
Whiteboard: [stockwell needswork]
Comment hidden (Intermittent Failures Robot) |
Comment hidden (Intermittent Failures Robot) |
Updated•7 years ago
|
Keywords: leave-open
Whiteboard: [stockwell needswork] → [stockwell disabled]
Pushed by gbrown@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6d22a46fce1f Skip test browser_ext_devtools_panels_elements.js for frequent intermittent failures; r=me,test-only
Updated•7 years ago
|
Component: WebExtensions: Untriaged → WebExtensions: Developer Tools
Flags: needinfo?(lgreco)
Comment 7•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6d22a46fce1f
Assignee | ||
Comment 8•7 years ago
|
||
Thanks Kris, I didn't noticed that this test got disabled because of it is intermittent. Looking at the source of these selection events, the onNewRoot handler from the devtools inspector: - http://searchfox.org/mozilla-central/rev/e8c36327cd8c9432c69e5e1383156a74330f11f2/devtools/client/inspector/inspector.js#764-788 I'm pretty sure that the reason of the intermittent failure is that: - while the first `this.selection.setNodeFront(null);` is always guaranteed to be called - the second one (`this.selection.setNodeFront(defaultNode, "navigateaway");`) can be cancelled by the early return at line 774 I'm going to tweak the test so that it doesn't assume that it is always going to receive 2 `undefined` selections before the final 'new body element' selection (once the page has been completely reloaded and the devtools inspector and it finally fires the new body element as the new selected element).
Assignee: nobody → lgreco
Status: NEW → ASSIGNED
Flags: needinfo?(lgreco)
Flags: needinfo?(amckay)
Priority: -- → P2
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8898805 -
Flags: review?(aswan)
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8898805 [details] Bug 1382487 - Fix devtools onSelectionChanged API event test case intermittency. https://reviewboard.mozilla.org/r/170184/#review175616
Attachment #8898805 -
Flags: review?(aswan) → review+
Comment hidden (Intermittent Failures Robot) |
Comment 12•7 years ago
|
||
Pushed by luca.greco@alcacoop.it: https://hg.mozilla.org/integration/autoland/rev/d4570ea6ffa1 Fix devtools onSelectionChanged API event test case intermittency. r=aswan
Comment 13•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/d4570ea6ffa1
Updated•7 years ago
|
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Keywords: leave-open
Resolution: --- → FIXED
Whiteboard: [stockwell disabled] → [stockwell fixed:other]
Updated•7 years ago
|
Comment hidden (Intermittent Failures Robot) |
Comment 15•7 years ago
|
||
bugherder uplift |
https://hg.mozilla.org/releases/mozilla-beta/rev/d41a551ff96e
Updated•6 years ago
|
Product: Toolkit → WebExtensions
You need to log in
before you can comment on or make changes to this bug.
Description
•