Closed Bug 1382487 Opened 2 years ago Closed 2 years ago
_ext _devtools _panels _elements .js | Got the expected on Selection Changed once the tab navigated - Got BODY, expected undefined
59 bytes, text/x-review-board-request
:andym, this has a high failure rate last week and a higher failure rate this week (when looking at the graph for august). can you find someone to look into this as it appears to be a persistent failure.
Whiteboard: [stockwell needswork]
Whiteboard: [stockwell needswork] → [stockwell disabled]
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/6d22a46fce1f Skip test browser_ext_devtools_panels_elements.js for frequent intermittent failures; r=me,test-only
Component: WebExtensions: Untriaged → WebExtensions: Developer Tools
Thanks Kris, I didn't noticed that this test got disabled because of it is intermittent. Looking at the source of these selection events, the onNewRoot handler from the devtools inspector: - http://searchfox.org/mozilla-central/rev/e8c36327cd8c9432c69e5e1383156a74330f11f2/devtools/client/inspector/inspector.js#764-788 I'm pretty sure that the reason of the intermittent failure is that: - while the first `this.selection.setNodeFront(null);` is always guaranteed to be called - the second one (`this.selection.setNodeFront(defaultNode, "navigateaway");`) can be cancelled by the early return at line 774 I'm going to tweak the test so that it doesn't assume that it is always going to receive 2 `undefined` selections before the final 'new body element' selection (once the page has been completely reloaded and the devtools inspector and it finally fires the new body element as the new selected element).
Assignee: nobody → lgreco
Status: NEW → ASSIGNED
Priority: -- → P2
Attachment #8898805 - Flags: review?(aswan)
Comment on attachment 8898805 [details] Bug 1382487 - Fix devtools onSelectionChanged API event test case intermittency. https://reviewboard.mozilla.org/r/170184/#review175616
Attachment #8898805 - Flags: review?(aswan) → review+
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/d4570ea6ffa1 Fix devtools onSelectionChanged API event test case intermittency. r=aswan
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Whiteboard: [stockwell disabled] → [stockwell fixed:other]
You need to log in before you can comment on or make changes to this bug.