1382487 - Intermittent browser/components/extensions/test/browser/test-oop-extensions/browser_ext_devtools_panels_elements.js | Got the expected onSelectionChanged once the tab navigated - Got BODY, expected undefined

Status: RESOLVED FIXED

(WebExtensions :: Developer Tools, defect, P2)

Description

[Treeherder Bug Filer]

Filed by: wkocher [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=115628450&repo=mozilla-inbound

https://queue.taskcluster.net/v1/task/S6nNpj3CRounTsCtbbaisQ/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Intermittent Failures Robot]

12 failures in 822 pushes (0.015 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* autoland: 7
* mozilla-inbound: 4
* try: 1

Platform breakdown:
* windows8-64: 6
* windows7-32: 2
* osx-10-10: 2
* windows10-64: 1
* linux64: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1382487&startday=2017-07-17&endday=2017-07-23&tree=all

Comment 2

[Intermittent Failures Robot]

40 failures in 1008 pushes (0.04 failures/push) were associated with this bug in the last 7 days.   

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* autoland: 22
* mozilla-inbound: 10
* mozilla-central: 7
* try: 1

Platform breakdown:
* windows7-32: 27
* windows7-32-vm: 6
* windows8-64: 3
* osx-10-10: 3
* linux64-ccov: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1382487&startday=2017-07-24&endday=2017-07-30&tree=all

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

:andym, this has a high failure rate last week and a higher failure rate this week (when looking at the graph for august).  can you find someone to look into this as it appears to be a persistent failure.

Comment 4

[Intermittent Failures Robot]

63 failures in 888 pushes (0.071 failures/push) were associated with this bug in the last 7 days. 

This is the #21 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* mozilla-inbound: 30
* autoland: 25
* mozilla-central: 4
* try: 3
* mozilla-beta: 1

Platform breakdown:
* windows7-32: 26
* windows8-64: 23
* osx-10-10: 9
* linux64: 3
* macosx64-devedition: 1
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1382487&startday=2017-07-31&endday=2017-08-06&tree=all

Comment 5

[Intermittent Failures Robot]

53 failures in 901 pushes (0.059 failures/push) were associated with this bug in the last 7 days. 

This is the #28 most frequent failure this week.  

** This failure happened more than 30 times this week! Resolving this bug is a high priority. **

** Try to resolve this bug as soon as possible. If unresolved for 2 weeks, the affected test(s) may be disabled. ** 

Repository breakdown:
* autoland: 26
* mozilla-inbound: 10
* try: 6
* mozilla-beta: 6
* mozilla-central: 5

Platform breakdown:
* windows8-64: 17
* windows7-32: 13
* osx-10-10: 10
* linux64: 9
* windows7-32-devedition: 3
* macosx64-nightly: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1382487&startday=2017-08-07&endday=2017-08-13&tree=all

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6d22a46fce1f
Skip test browser_ext_devtools_panels_elements.js for frequent intermittent failures; r=me,test-only

Comment 7

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/6d22a46fce1f

Comment 8

[Luca Greco [:rpl] [:luca] [:lgreco]]

Thanks Kris,
I didn't noticed that this test got disabled because of it is intermittent.

Looking at the source of these selection events, the onNewRoot handler from the devtools inspector:

- http://searchfox.org/mozilla-central/rev/e8c36327cd8c9432c69e5e1383156a74330f11f2/devtools/client/inspector/inspector.js#764-788

I'm pretty sure that the reason of the intermittent failure is that:
- while the first `this.selection.setNodeFront(null);` is always guaranteed to be called 
- the second one (`this.selection.setNodeFront(defaultNode, "navigateaway");`) can be cancelled by the early return at line 774

I'm going to tweak the test so that it doesn't assume that it is always going to receive 2 `undefined` selections before the final 'new body element' selection (once the page has been completely reloaded and the devtools inspector and it finally fires the new body element as the new selected element).

Comment 9

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1382487 - Fix devtools onSelectionChanged API event test case intermittency.

Review commit: https://reviewboard.mozilla.org/r/170184/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/170184/

Comment 10

[Andrew Swan [:aswan]]

Comment on attachment 8898805 [details]
Bug 1382487 - Fix devtools onSelectionChanged API event test case intermittency.

https://reviewboard.mozilla.org/r/170184/#review175616

Comment 11

[Intermittent Failures Robot]

17 failures in 949 pushes (0.018 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* autoland: 7
* mozilla-beta: 6
* mozilla-inbound: 2
* mozilla-central: 2

Platform breakdown:
* windows7-32: 6
* windows8-64: 5
* osx-10-10: 2
* macosx64-nightly: 2
* linux64-ccov: 1
* linux32-devedition: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1382487&startday=2017-08-14&endday=2017-08-20&tree=all

Comment 12

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d4570ea6ffa1
Fix devtools onSelectionChanged API event test case intermittency. r=aswan

Comment 13

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/d4570ea6ffa1

Comment 14

[Intermittent Failures Robot]

2 failures in 908 pushes (0.002 failures/push) were associated with this bug in the last 7 days.   

Repository breakdown:
* try: 1
* mozilla-beta: 1

Platform breakdown:
* windows8-64: 1
* linux32: 1

For more details, see:
https://brasstacks.mozilla.com/orangefactor/?display=Bug&bugid=1382487&startday=2017-08-21&endday=2017-08-27&tree=all

Comment 15

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/d41a551ff96e