1382530 - Unhide address and creditcard sync engines

Status: RESOLVED FIXED

(Firefox :: Sync, enhancement, P3)

Description

[Mark Hammond [:markh] [:mhammond]]

Most of the bug tree under 1361010 is landing new sync engines to support autofill, however, the engines are hidden (ie, not just disabled, but completely hidden) via preferences:

> pref("services.sync.engine.addresses.available", false);
> pref("services.sync.engine.creditcards.available", false);

These need to be flipped to true (and the browser restarted) for testing. We also need to default them to true at some appropriate time.

Comment 1

[Luke Chang [:lchang] (inactive)]

Both address and creditcard sync engines have been enabled by default.

Comment 2

[Thom Chiovoloni [:tcsc] (ex-moco)]

On a reasonably fresh Linux install of 57, only credit cards is enabled for me. Addresses is not available at all.

I'm not sure what would help most for debugging this, but

extensions.formautofill.addresses.enabled;true
services.sync.engine.addresses;true
services.sync.engine.addresses.available;false

extensions.formautofill.creditCards.available;true
extensions.formautofill.creditCards.enabled;true
services.sync.engine.creditcards;true
services.sync.engine.creditcards.available;true

It's not clear to me if this is a bug or not, so I won't reopen (yet).

Comment 3

[Matthew N. [:MattN]]

What about extensions.formautofill.available? I think it's probably "detect" and so it depends on a geolocation pref (browser.search.countryCode) which only gets set after some time in a new profile. After a restart if it detects you are in the US then the feature should appear.

Comment 4

[Thom Chiovoloni [:tcsc] (ex-moco)]

extensions.formautofill.available is staged-rollout.

Upon further investigation, it seems like formautofill itself should be disabled, and so I think the bug here is that services.sync.engine.creditcards.available is true. This leads to having settings like this, despite this client not actually being able to sync them.


[0]: https://irccloud.mozilla.com/file/e61PtFl3/Screen%20Shot%202017-11-27%20at%202.02.17%20PM.png

Comment 5

[Luke Chang [:lchang] (inactive)]

That's weird. We don't even mention "services.sync.engine.creditcards.available" in the formautofill add-on in Fx57. Is it set by other modules?