Closed
Bug 1382531
Opened 7 years ago
Closed 7 years ago
rewrite crashtest for data: URI is unique opaque origin
Categories
(Core :: DOM: Security, defect)
Core
DOM: Security
Tracking
()
RESOLVED
FIXED
mozilla56
Tracking | Status | |
---|---|---|
firefox56 | --- | fixed |
People
(Reporter: allstars.chh, Assigned: allstars.chh)
References
Details
(Whiteboard: [domsecurity-active])
Attachments
(2 files, 1 obsolete file)
18.72 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
1.51 KB,
patch
|
smaug
:
review+
|
Details | Diff | Splinter Review |
No description provided.
Assignee | ||
Comment 1•7 years ago
|
||
Assignee | ||
Comment 2•7 years ago
|
||
Comment on attachment 8888735 [details] [diff] [review] Patch. Review of attachment 8888735 [details] [diff] [review]: ----------------------------------------------------------------- ::: docshell/base/crashtests/file_914521.html @@ +13,5 @@ > + window.addEventListener("popstate", spin); > + window.close(); > + window.location = "#c"; > + //TODO: JavaScript error: file:///home/allstars/src/gecko-dev/docshell/base/crashtests/file_914521.html, line 16: ReferenceError: finish is not defined > + //finish(); Smaug, do you know how should I fix this? finsih is defined in 914521.html However in crashtest it can't find 'finish'.
Attachment #8888735 -
Flags: feedback?(bugs)
Comment 3•7 years ago
|
||
(In reply to Yoshi Huang [:allstars.chh] from comment #2) > Smaug, do you know how should I fix this? > finsih is defined in 914521.html > However in crashtest it can't find 'finish'. You could use a postMessage handler and report back to the main page that the test is finished and then actually call finish() i the .html file.
Comment 4•7 years ago
|
||
Comment on attachment 8888735 [details] [diff] [review] Patch. yeah, use postMessage, or can you use opener.Simpletest.finish() or some such?
Attachment #8888735 -
Flags: feedback?(bugs)
Assignee | ||
Comment 5•7 years ago
|
||
Yeah, forgot to mention that I've tried this before, however window.opener is null. But I don't have this problem when running it as a normal page. I'll get more context from bug 914521. Thanks
Assignee | ||
Comment 6•7 years ago
|
||
Attachment #8888735 -
Attachment is obsolete: true
Assignee | ||
Comment 7•7 years ago
|
||
Assignee | ||
Updated•7 years ago
|
Attachment #8889349 -
Flags: review?(bugs)
Assignee | ||
Updated•7 years ago
|
Attachment #8889350 -
Flags: review?(bugs)
Comment 8•7 years ago
|
||
Comment on attachment 8889349 [details] [diff] [review] Part 1: fix crashtest failiure when data URI is unique origin. rs+
Attachment #8889349 -
Flags: review?(bugs) → review+
Updated•7 years ago
|
Attachment #8889350 -
Flags: review?(bugs) → review+
Pushed by yhuang@mozilla.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/808600f02441 Part 1: rewrite crashtest for data: URI is unique opaque origin. r=smaug https://hg.mozilla.org/integration/mozilla-inbound/rev/49eda81bca01 Part 2: add pref for docshell/base/crashtests/914521.html. r=smaug
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/808600f02441 https://hg.mozilla.org/mozilla-central/rev/49eda81bca01
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla56
You need to log in
before you can comment on or make changes to this bug.
Description
•