1382557 - Doesn't show the correct duration for media

Status: RESOLVED FIXED

(Core :: Audio/Video: Playback, defect, P3)

Description

[Alastor Wu [:alwu]]

Tested on OSX with FF54 and Nightly56.0a1. 

STR.
1. go to https://media-testing.updog.co/using.mp4

Expected.
2. video should show the correct duration

Actual.
2. video doesn't show the total duration of video

Comment 1

[Alfredo Yang (:alfredo)]

Ths duration is ok when plays locally.

Comment 2

[Alastor Wu [:alwu]]

It's regression because I could see the duration before, but I've already forgotten what's the version I used. (maybe 53 or 52)

Comment 3

[Alfredo Yang (:alfredo)]

DurationChanged() is called before demuxer parsing in network case.

Comment 4

[Alfredo Yang (:alfredo)]

(In reply to Alastor Wu [:alwu][please needinfo? me][7/26-8/3 PTO] from comment #2)
> It's regression because I could see the duration before, but I've already
> forgotten what's the version I used. (maybe 53 or 52)

Yeah, it reminds me bug 1370177. :-)

Comment 5

[Alastor Wu [:alwu]]

Issue can also see on this URL, it seems very easy to be reproduced.

https://media-testing.updog.co/Toe.mp3

Comment 6

[JW Wang [:jwwang] [:jw_wang]]

Attachment: Bug 1382557 - the duration should be finite when we can get one from the metadata.

This fixes the case where ChannelMediaResource::OnStartRequest() calls
mCallback->SetInfinite(true) to report an infinite duration, yet later
we get another duratoin from the metadata.

http://searchfox.org/mozilla-central/rev/8a61c71153a79cda2e1ae7d477564347c607cc5f/dom/media/MediaDecoder.cpp#1179-1185
Note IsInfinite() is checked before other duration sources. We need to call
SetInfinite(false) on the MediaDecoder so we can get the correct duration.

Review commit: https://reviewboard.mozilla.org/r/161364/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/161364/

Comment 7

[Chris Pearce [:cpearce (Not reading bugmail)]]

Comment on attachment 8890241 [details]
Bug 1382557 - the duration should be finite when we can get one from the metadata.

https://reviewboard.mozilla.org/r/161364/#review167130

::: dom/media/MediaDecoder.cpp:768
(Diff revision 1)
>    Invalidate();
>  
>    EnsureTelemetryReported();
> +
> +  // The duration is no longer infinite when we get one from the metadata.
> +  if (mInfo->mMetadataDuration && IsInfinite()) {

We could also have IsInfinite() check whether we've got a duration from the metadata, rather than relying on manually setting the state here.

I'll let you make the decision as to which approach to use here.

Comment 8

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8890241 [details]
Bug 1382557 - the duration should be finite when we can get one from the metadata.

https://reviewboard.mozilla.org/r/161364/#review167130

> We could also have IsInfinite() check whether we've got a duration from the metadata, rather than relying on manually setting the state here.
> 
> I'll let you make the decision as to which approach to use here.

SGTM. I will take your approach. Thanks!

Comment 9

[JW Wang [:jwwang] [:jw_wang]]

Comment on attachment 8890241 [details]
Bug 1382557 - the duration should be finite when we can get one from the metadata.

https://reviewboard.mozilla.org/r/161364/#review167130

> SGTM. I will take your approach. Thanks!

It turns out that the duration is not updated unless you invoke DurationChanged() manually in MetadataLoaded(). This is because DurationChanged() is triggered by mStateMachineDuration (state-mirroring) before MetadataLoaded() is called. So I have to stick to the original approach though.

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/52ea7b299388
the duration should be finite when we can get one from the metadata. r=cpearce

Comment 11

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/52ea7b299388

Comment 12

[Rezaul Huque Nayeem]

Successfully Reproduced the bug in Nightly 56.0a1 (2017-07-20) on windows 10 x64

Verified as fixed with latest Firefox Beta 56.0b2 (Build ID: 20170810180547) 

Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:56.0) Gecko/20100101 Firefox/56.0

Comment 13

[Md Maruf Rahman]

I have reproduced this bug with Nightly 56.0a1 (2017-07-20) on ubuntu 16.04 LTS!

This bug's fix is verified with latest Beta!


Build  ID  : 20170818155657 
User Agent : Mozilla/5.0 (X11; Linux x86_64; rv:56.0) Gecko/20100101 Firefox/56.0

[bugday-20170816]